netdev - Re: [PATCH net-next 04/13] net: dsa: sja1105: cache the phy-mode port property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e328757c-c59c-9594-3b5a-e26ed2ea479c@gmail.com>
Date:   Mon, 24 May 2021 19:19:10 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 04/13] net: dsa: sja1105: cache the phy-mode port
 property



On 5/24/2021 4:22 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> So far we've succeeded in operating without keeping a copy of the
> phy-mode in the driver, since we already have the static config and we
> can look at the xMII Mode Parameters Table which already holds that
> information.
> 
> But with the SJA1110, we cannot make the distinction between sgmii and
> 2500base-x, because to the hardware's static config, it's all SGMII.
> So add a phy_mode property per port inside struct sja1105_private.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian