netdev - Re: [PATCH bpf-next 4/5] libbpf: streamline error reporting for high-level APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzYQc+ijF78vX14CXi9My7hJ_+XNpnh1ZcMjpcdT1czHmA@mail.gmail.com>
Date:   Mon, 24 May 2021 17:15:02 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Andrii Nakryiko <andrii@...nel.org>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next 4/5] libbpf: streamline error reporting for
 high-level APIs

On Mon, May 24, 2021 at 4:49 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Fri, May 21, 2021 at 04:42:58PM -0700, Andrii Nakryiko wrote:
> >
> > +/* this goes away in libbpf 1.0 */
> > +enum libbpf_strict_mode libbpf_mode = LIBBPF_STRICT_NONE;
> > +
> > +int libbpf_set_strict_mode(enum libbpf_strict_mode mode)
> > +{
> > +     /* __LIBBPF_STRICT_LAST is the last power-of-2 value used + 1, so to
> > +      * get all possible values we compensate last +1, and then (2*x - 1)
> > +      * to get the bit mask
> > +      */
> > +     if (mode != LIBBPF_STRICT_ALL
> > +         && mode & ~((__LIBBPF_STRICT_LAST - 1) * 2 - 1))
> > +             return libbpf_err(-EINVAL);
> > +
> > +     libbpf_mode = mode;
> > +     return 0;
> > +}
>
> This hunk should be in patch 1, right?
> Otherwise bisection will be broken.

Yeah, I screwed up splitting those changes into patches :( Thanks for
noticing, I'll send fixed v2 a bit later tonight.