netdev - Re: [PATCH ipsec-next] xfrm: add state hashtable keyed by seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210525102452.GX40979@gauss3.secunet.de>
Date:   Tue, 25 May 2021 12:24:52 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec-next] xfrm: add state hashtable keyed by seq

On Sun, Apr 25, 2021 at 09:47:12PM +0200, Sabrina Dubroca wrote:
> When creating new states with seq set in xfrm_usersa_info, we walk
> through all the states already installed in that netns to find a
> matching ACQUIRE state (__xfrm_find_acq_byseq, called from
> xfrm_state_add). This causes severe slowdowns on systems with a large
> number of states.
> 
> This patch introduces a hashtable using x->km.seq as key, so that the
> corresponding state can be found in a reasonable time.
> 
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Now applied to ipsec-next, thanks a lot Sabrina!