netdev - Re: [PATCH v2] Bluetooth: disable filter dup when scan for adv monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <AE7453FB-1E39-422A-91FB-C136343B2991@holtmann.org>
Date:   Wed, 26 May 2021 17:17:49 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Howard Chung <howardchung@...gle.com>
Cc:     linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@...omium.org>,
        Yun-Hao Chung <howardchung@...omium.org>,
        Archie Pusaka <apusaka@...omium.org>,
        Manish Mandlik <mmandlik@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: disable filter dup when scan for adv
 monitor

Hi Howard,

> Disable duplicates filter when scanning for advertisement monitor for
> the following reasons. The scanning includes active scan and passive
> scan.
> 
> For HW pattern filtering (ex. MSFT), Realtek and Qualcomm controllers
> ignore RSSI_Sampling_Period when the duplicates filter is enabled.
> 
> For SW pattern filtering, when we're not doing interleaved scanning, it
> is necessary to disable duplicates filter, otherwise hosts can only
> receive one advertisement and it's impossible to know if a peer is still
> in range.
> 
> Reviewed-by: Archie Pusaka <apusaka@...omium.org>
> Reviewed-by: Manish Mandlik <mmandlik@...omium.org>
> 
> Signed-off-by: Yun-Hao Chung <howardchung@...omium.org>
> 
> ---
> 
> Changes in v2:
> - include the vendor name in the comment and commit messages
> 
> net/bluetooth/hci_request.c | 46 +++++++++++++++++++++++++++++++++----
> 1 file changed, 41 insertions(+), 5 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel