netdev - Re: [PATCH v2] dt-bindings: net: Convert MDIO mux bindings to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YK6YljEYXprM/8iD@lunn.ch>
Date:   Wed, 26 May 2021 20:51:02 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] dt-bindings: net: Convert MDIO mux bindings to DT
 schema

On Wed, May 26, 2021 at 01:14:11PM -0500, Rob Herring wrote:
> Convert the common MDIO mux bindings to DT schema.
> 
> Drop the example from mdio-mux.yaml as mdio-mux-gpio.yaml has the same one.
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Ray Jui <rjui@...adcom.com>
> Cc: Scott Branden <sbranden@...adcom.com>
> Cc: bcm-kernel-feedback-list@...adcom.com
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Heiner Kallweit <hkallweit1@...il.com>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: netdev@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

> +        mdio@2 {  // Slot 2 XAUI (FM1)
> +            reg = <2>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            ethernet-phy@4 {
> +                compatible = "ethernet-phy-ieee802.3-c45";
> +                reg = <0>;

reg should really be 4 here. The same error existed in the .txt
version. I guess the examples are never actually verified using the
yaml?

	Andrew