netdev - iproute2: ip address add prefer keyword confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGF1phaw5pe5y2acaoT2FqtMbZ0KXbzkg9ANAJoH=PVG=zJc7A@mail.gmail.com>
Date:   Thu, 27 May 2021 13:58:00 -0700
From:   Norman Rasmussen <norman@...mussen.co.za>
To:     netdev@...r.kernel.org
Subject: iproute2: ip address add prefer keyword confusion

commit 78d04c7b27cf ("ipaddress: Add support for address metric")
added "priority" and "preference" as aliases for the "metric" keyword,
but they are entirely undocumented.

I only noticed because I was adding addresses with a preferred
lifetime, but I was using "pref" as the keyword. The metric code was
added _above_ the lifetime code, so after the change "pref" matches
"preference", instead of "preferred_lft".

Is there an existing way to deal with conflicts between keyword
prefixes? Should "prefer" (or shorter) fail with a clear error
instead? Should the metric code have been added below the lifetime
code? Should it be moved or is it too late?

-- 
- Norman Rasmussen
 - Email: norman@...mussen.co.za
 - Home page: http://norman.rasmussen.co.za/