netdev - Re: [PATCH net-next 1/3] net: flow_dissector: extend bpf flow dissector support with vnet hdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210527161355.35cac718@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 27 May 2021 16:13:55 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tanner Love <tannerlove.kernel@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Tanner Love <tannerlove@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Petar Penkov <ppenkov@...gle.com>
Subject: Re: [PATCH net-next 1/3] net: flow_dissector: extend bpf flow
 dissector support with vnet hdr

On Thu, 27 May 2021 17:12:12 -0400 Tanner Love wrote:
> @@ -915,7 +916,8 @@ bool __skb_flow_dissect(const struct net *net,
>  			const struct sk_buff *skb,
>  			struct flow_dissector *flow_dissector,
>  			void *target_container, const void *data,
> -			__be16 proto, int nhoff, int hlen, unsigned int flags)
> +			__be16 proto, int nhoff, int hlen, unsigned int flags,
> +			const struct virtio_net_hdr *vhdr)
>  {
>  	struct flow_dissector_key_control *key_control;
>  	struct flow_dissector_key_basic *key_basic;

net/core/flow_dissector.c:922: warning: Function parameter or member 'vhdr' not described in '__skb_flow_dissect'

Please try to check W=1 C=1 builds, you may want to compile only the
object files you changed otherwise for a change like this, touching
skbuff.h, you'll drown in old warnings.