netdev - RE: [PATCH net-next] virtio_net: set link state down when virtqueue is broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 03:06:26 +0000
From:   wangyunjian <wangyunjian@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "mst@...hat.com" <mst@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        dingxiaoxiong <dingxiaoxiong@...wei.com>
Subject: RE: [PATCH net-next] virtio_net: set link state down when virtqueue
 is broken

> -----Original Message-----
> From: Jakub Kicinski [mailto:kuba@...nel.org]
> Sent: Thursday, May 27, 2021 8:28 AM
> To: wangyunjian <wangyunjian@...wei.com>
> Cc: netdev@...r.kernel.org; davem@...emloft.net; mst@...hat.com;
> jasowang@...hat.com; virtualization@...ts.linux-foundation.org;
> dingxiaoxiong <dingxiaoxiong@...wei.com>
> Subject: Re: [PATCH net-next] virtio_net: set link state down when virtqueue is
> broken
> 
> On Wed, 26 May 2021 19:39:51 +0800 wangyunjian wrote:
> > +	for (i = 0; i < vi->max_queue_pairs; i++) {
> > +		if (virtqueue_is_broken(vi->rq[i].vq) ||
> virtqueue_is_broken(vi->sq[i].vq)) {
> > +			netif_carrier_off(netdev);
> > +			netif_tx_stop_all_queues(netdev);
> > +			vi->broken = true;
> 
> Can't comment on the virtio specifics but the lack of locking between this and
> the code in virtnet_config_changed_work() seems surprising.

Thanks for your suggestion, will fix it in next version.

Yunjian