netdev - Re: [PATCH] drivers/net/sungem: Fix inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210526170937.4228f917@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 26 May 2021 17:09:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/net/sungem: Fix inconsistent indenting

On Wed, 26 May 2021 18:24:08 +0800 Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
> 
> drivers/net/sungem_phy.c:412 genmii_read_link() warn: inconsistent
> indenting.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/net/sungem_phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
> index 291fa44..4daac5f 100644
> --- a/drivers/net/sungem_phy.c
> +++ b/drivers/net/sungem_phy.c
> @@ -409,7 +409,7 @@ static int genmii_read_link(struct mii_phy *phy)
>  	 * though magic-aneg shouldn't prevent this case from occurring
>  	 */
>  
> -	 return 0;
> +	return 0;
>  }
>  
>  static int generic_suspend(struct mii_phy* phy)

Do you have any statistics on how many such patches we'd need to apply
to make the kernel free for such warning? If it's too many it's probably
not worth it, this patch for example has net zero effect on readability.