netdev - Re: [PATCH net-next] samples: pktgen: add UDP tx checksum support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210528143149.59e5543a@carbon>
Date:   Fri, 28 May 2021 14:31:49 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        brouer@...hat.com
Subject: Re: [PATCH net-next] samples: pktgen: add UDP tx checksum support

On Fri, 28 May 2021 13:22:21 +0200
Lorenzo Bianconi <lorenzo@...nel.org> wrote:

> Introduce k parameter in pktgen samples in order to toggle UDP tx
> checksum
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---

If you fix whitespace nits below:

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

>  samples/pktgen/parameters.sh                               | 7 ++++++-
>  samples/pktgen/pktgen_sample01_simple.sh                   | 2 ++
>  samples/pktgen/pktgen_sample02_multiqueue.sh               | 2 ++
>  samples/pktgen/pktgen_sample03_burst_single_flow.sh        | 2 ++
>  samples/pktgen/pktgen_sample04_many_flows.sh               | 2 ++
>  samples/pktgen/pktgen_sample05_flow_per_thread.sh          | 2 ++
>  .../pktgen_sample06_numa_awared_queue_irq_affinity.sh      | 2 ++
>  7 files changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/samples/pktgen/parameters.sh b/samples/pktgen/parameters.sh
> index b4c1b371e4b8..7a425fc260ee 100644
> --- a/samples/pktgen/parameters.sh
> +++ b/samples/pktgen/parameters.sh
[...]
> @@ -88,6 +89,10 @@ while getopts "s:i:d:m:p:f:t:c:n:b:w:vxh6a" option; do
>            export APPEND=yes
>            info "Append mode: APPEND=$APPEND"
>            ;;
> +	k)
> +	  export UDP_CSUM=yes
> +          info "UDP tx checksum: UDP_CSUM=$UDP_CSUM"
> +	  ;;

You whitespaces are off here... could you just use the existing (shell)
code use of whitespaces?  (else it looks silly when viewing with
different editors, you vim likely hides this looks off).

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer