netdev - Re: [PATCH net-next v2 4/7] ice: Implement iidc operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210528122939.3598f809@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Fri, 28 May 2021 12:29:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Cc:     "jgg@...dia.com" <jgg@...dia.com>,
        "Ertman, David M" <david.m.ertman@...el.com>,
        "leonro@...dia.com" <leonro@...dia.com>,
        "Saleem, Shiraz" <shiraz.saleem@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 4/7] ice: Implement iidc operations

On Fri, 28 May 2021 16:48:17 +0000 Nguyen, Anthony L wrote:
> On Fri, 2021-05-28 at 10:02 -0300, Jason Gunthorpe wrote:
> > > 
> > > defensive programming  
> 
> Will remove this.
>
> > > RDMA folks, are you okay with drivers inventing their own error
> > > codes?  
> > 
> > Not really, I was ignoring it because it looks like big part of their
> > netdev driver layer.  
> 
> We have looked into how we can eliminate/minimize the use of ice_status
> and our assessment is that this will take a decent amount of work. We
> are trying to get this done.

Sorry I don't speak managerese.

I asked you to stop using your own error codes multiple times, and 
now you're about to pollute another subsystem with the same problem.

Please fix.