| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20210528195946.2375109-7-memxor@gmail.com>
Date: Sat, 29 May 2021 01:29:45 +0530
From: Kumar Kartikeya Dwivedi <memxor@...il.com>
To: bpf@...r.kernel.org
Cc: Kumar Kartikeya Dwivedi <memxor@...il.com>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko <andrii@...nel.org>,
Martin KaFai Lau <kafai@...com>,
Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
John Fastabend <john.fastabend@...il.com>,
KP Singh <kpsingh@...nel.org>,
Jamal Hadi Salim <jhs@...atatu.com>,
Vlad Buslov <vladbu@...dia.com>,
Cong Wang <xiyou.wangcong@...il.com>,
Jiri Pirko <jiri@...nulli.us>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, Joe Stringer <joe@...ium.io>,
Quentin Monnet <quentin@...valent.com>,
Jesper Dangaard Brouer <brouer@...hat.com>,
Toke Høiland-Jørgensen <toke@...hat.com>,
netdev@...r.kernel.org
Subject: [PATCH RFC bpf-next 6/7] libbpf: add bpf_link based TC-BPF management API
This adds userspace TC-BPF management API based on bpf_link.
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@...il.com>
---
tools/lib/bpf/bpf.c | 5 ++++
tools/lib/bpf/bpf.h | 8 +++++-
tools/lib/bpf/libbpf.c | 59 ++++++++++++++++++++++++++++++++++++++--
tools/lib/bpf/libbpf.h | 17 ++++++++++++
tools/lib/bpf/libbpf.map | 1 +
tools/lib/bpf/netlink.c | 5 ++--
tools/lib/bpf/netlink.h | 8 ++++++
7 files changed, 98 insertions(+), 5 deletions(-)
create mode 100644 tools/lib/bpf/netlink.h
diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
index 86dcac44f32f..ab2e2e9ccc5e 100644
--- a/tools/lib/bpf/bpf.c
+++ b/tools/lib/bpf/bpf.c
@@ -28,6 +28,7 @@
#include <asm/unistd.h>
#include <errno.h>
#include <linux/bpf.h>
+#include <arpa/inet.h>
#include "bpf.h"
#include "libbpf.h"
#include "libbpf_internal.h"
@@ -692,6 +693,10 @@ int bpf_link_create(int prog_fd, int target_fd,
attr.link_create.target_fd = target_fd;
attr.link_create.attach_type = attach_type;
attr.link_create.flags = OPTS_GET(opts, flags, 0);
+ attr.link_create.tc.parent = OPTS_GET(opts, tc.parent, 0);
+ attr.link_create.tc.handle = OPTS_GET(opts, tc.handle, 0);
+ attr.link_create.tc.priority = OPTS_GET(opts, tc.priority, 0);
+ attr.link_create.tc.gen_flags = OPTS_GET(opts, tc.gen_flags, 0);
if (iter_info_len) {
attr.link_create.iter_info =
diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
index 4f758f8f50cd..f2178309e9ea 100644
--- a/tools/lib/bpf/bpf.h
+++ b/tools/lib/bpf/bpf.h
@@ -177,8 +177,14 @@ struct bpf_link_create_opts {
union bpf_iter_link_info *iter_info;
__u32 iter_info_len;
__u32 target_btf_id;
+ struct {
+ __u32 parent;
+ __u32 handle;
+ __u32 priority;
+ __u32 gen_flags;
+ } tc;
};
-#define bpf_link_create_opts__last_field target_btf_id
+#define bpf_link_create_opts__last_field tc.gen_flags
LIBBPF_API int bpf_link_create(int prog_fd, int target_fd,
enum bpf_attach_type attach_type,
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 1c4e20e75237..7809536980b1 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -55,6 +55,7 @@
#include "libbpf_internal.h"
#include "hashmap.h"
#include "bpf_gen_internal.h"
+#include "netlink.h"
#ifndef BPF_FS_MAGIC
#define BPF_FS_MAGIC 0xcafe4a11
@@ -7185,7 +7186,7 @@ static int bpf_object__collect_relos(struct bpf_object *obj)
for (i = 0; i < obj->nr_programs; i++) {
struct bpf_program *p = &obj->programs[i];
-
+
if (!p->nr_reloc)
continue;
@@ -10005,7 +10006,7 @@ struct bpf_link {
int bpf_link__update_program(struct bpf_link *link, struct bpf_program *prog)
{
int ret;
-
+
ret = bpf_link_update(bpf_link__fd(link), bpf_program__fd(prog), NULL);
return libbpf_err_errno(ret);
}
@@ -10613,6 +10614,60 @@ struct bpf_link *bpf_program__attach_xdp(struct bpf_program *prog, int ifindex)
return bpf_program__attach_fd(prog, ifindex, 0, "xdp");
}
+struct bpf_link *bpf_program__attach_tc(struct bpf_program *prog,
+ const struct bpf_tc_hook *hook,
+ const struct bpf_tc_link_opts *opts)
+{
+ DECLARE_LIBBPF_OPTS(bpf_link_create_opts, lopts, 0);
+ char errmsg[STRERR_BUFSIZE];
+ int prog_fd, link_fd, ret;
+ struct bpf_link *link;
+ __u32 parent;
+
+ if (!hook || !OPTS_VALID(hook, bpf_tc_hook) ||
+ !OPTS_VALID(opts, bpf_tc_link_opts))
+ return ERR_PTR(-EINVAL);
+
+ if (OPTS_GET(hook, ifindex, 0) <= 0 ||
+ OPTS_GET(opts, priority, 0) > UINT16_MAX)
+ return ERR_PTR(-EINVAL);
+
+ parent = OPTS_GET(hook, parent, 0);
+
+ ret = tc_get_tcm_parent(OPTS_GET(hook, attach_point, 0),
+ &parent);
+ if (ret < 0)
+ return ERR_PTR(ret);
+
+ lopts.tc.parent = parent;
+ lopts.tc.handle = OPTS_GET(opts, handle, 0);
+ lopts.tc.priority = OPTS_GET(opts, priority, 0);
+ lopts.tc.gen_flags = OPTS_GET(opts, gen_flags, 0);
+
+ prog_fd = bpf_program__fd(prog);
+ if (prog_fd < 0) {
+ pr_warn("prog '%s': can't attach before loaded\n", prog->name);
+ return ERR_PTR(-EINVAL);
+ }
+
+ link = calloc(1, sizeof(*link));
+ if (!link)
+ return ERR_PTR(-ENOMEM);
+ link->detach = &bpf_link__detach_fd;
+
+ link_fd = bpf_link_create(prog_fd, OPTS_GET(hook, ifindex, 0), BPF_TC, &lopts);
+ if (link_fd < 0) {
+ link_fd = -errno;
+ free(link);
+ pr_warn("prog '%s': failed to attach tc filter: %s\n",
+ prog->name, libbpf_strerror_r(link_fd, errmsg, sizeof(errmsg)));
+ return ERR_PTR(link_fd);
+ }
+ link->fd = link_fd;
+
+ return link;
+}
+
struct bpf_link *bpf_program__attach_freplace(struct bpf_program *prog,
int target_fd,
const char *attach_func_name)
diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
index 6e61342ba56c..284a446c6513 100644
--- a/tools/lib/bpf/libbpf.h
+++ b/tools/lib/bpf/libbpf.h
@@ -282,6 +282,23 @@ LIBBPF_API struct bpf_link *
bpf_program__attach_iter(struct bpf_program *prog,
const struct bpf_iter_attach_opts *opts);
+/* TC bpf_link related API */
+struct bpf_tc_hook;
+
+struct bpf_tc_link_opts {
+ size_t sz;
+ __u32 handle;
+ __u32 priority;
+ __u32 gen_flags;
+ size_t :0;
+};
+#define bpf_tc_link_opts__last_field gen_flags
+
+LIBBPF_API struct bpf_link *
+bpf_program__attach_tc(struct bpf_program *prog,
+ const struct bpf_tc_hook *hook,
+ const struct bpf_tc_link_opts *opts);
+
struct bpf_insn;
/*
diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map
index bbe99b1db1a9..ef570a840aca 100644
--- a/tools/lib/bpf/libbpf.map
+++ b/tools/lib/bpf/libbpf.map
@@ -373,5 +373,6 @@ LIBBPF_0.4.0 {
LIBBPF_0.5.0 {
global:
+ bpf_program__attach_tc;
libbpf_set_strict_mode;
} LIBBPF_0.4.0;
diff --git a/tools/lib/bpf/netlink.c b/tools/lib/bpf/netlink.c
index d743c8721aa7..b7ac36fc9c1a 100644
--- a/tools/lib/bpf/netlink.c
+++ b/tools/lib/bpf/netlink.c
@@ -17,6 +17,7 @@
#include "libbpf.h"
#include "libbpf_internal.h"
#include "nlattr.h"
+#include "netlink.h"
#ifndef SOL_NETLINK
#define SOL_NETLINK 270
@@ -405,8 +406,8 @@ static int attach_point_to_config(struct bpf_tc_hook *hook,
}
}
-static int tc_get_tcm_parent(enum bpf_tc_attach_point attach_point,
- __u32 *parent)
+int tc_get_tcm_parent(enum bpf_tc_attach_point attach_point,
+ __u32 *parent)
{
switch (attach_point) {
case BPF_TC_INGRESS:
diff --git a/tools/lib/bpf/netlink.h b/tools/lib/bpf/netlink.h
new file mode 100644
index 000000000000..c89133d56eb4
--- /dev/null
+++ b/tools/lib/bpf/netlink.h
@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
+#pragma once
+
+#include <linux/types.h>
+#include "libbpf.h"
+
+int tc_get_tcm_parent(enum bpf_tc_attach_point attach_point,
+ __u32 *parent);
--
2.31.1
Powered by blists - more mailing lists