netdev - Re: [PATCH net-next 3/8] nfp: flower-ct: add ct zone table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210528145648.68eae3cb@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Fri, 28 May 2021 14:56:48 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...igine.com, Louis Peens <louis.peens@...igine.com>,
        Yinjun Zhang <yinjun.zhang@...igine.com>
Subject: Re: [PATCH net-next 3/8] nfp: flower-ct: add ct zone table

On Fri, 28 May 2021 16:42:41 +0200 Simon Horman wrote:
> From: Louis Peens <louis.peens@...igine.com>
> 
> Add initial zone table to nfp_flower_priv. This table will be used
> to store all the information required to offload conntrack.
> 
> Signed-off-by: Louis Peens <louis.peens@...igine.com>
> Signed-off-by: Yinjun Zhang <yinjun.zhang@...igine.com>
> Signed-off-by: Simon Horman <simon.horman@...igine.com>

> @@ -193,6 +193,7 @@ struct nfp_fl_internal_ports {
>   * @qos_stats_lock:	Lock on qos stats updates
>   * @pre_tun_rule_cnt:	Number of pre-tunnel rules offloaded
>   * @merge_table:	Hash table to store merged flows
> + * @ct_zone_table	Hash table used to store the different zones

Missing :

> +static void nfp_free_zone_table_entry(void *ptr, void *arg)
> +{
> +	struct nfp_fl_ct_zone_entry *zt = ptr;
> +}

drivers/net/ethernet/netronome/nfp/flower/metadata.c:588:31: warning: unused variable ‘zt’ [-Wunused-variable]
  588 |  struct nfp_fl_ct_zone_entry *zt = ptr;
      |                               ^~