netdev - Re: [PATCH net-next v2 8/8] nfp: flower-ct: add tc merge functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnP8Zb_MPukyNrFNWN9+--bQROQOqTV=K_cLngR_kmUMNJSDg@mail.gmail.com>
Date:   Mon, 31 May 2021 18:24:37 +0000
From:   Marcelo Ricardo Leitner <mleitner@...hat.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        oss-drivers@...igine.com, Louis Peens <louis.peens@...igine.com>,
        Yinjun Zhang <yinjun.zhang@...igine.com>
Subject: Re: [PATCH net-next v2 8/8] nfp: flower-ct: add tc merge functionality

On Mon, May 31, 2021 at 02:46:07PM +0200, Simon Horman wrote:
> +static int nfp_ct_do_tc_merge(struct nfp_fl_ct_zone_entry *zt,
> +			      struct nfp_fl_ct_flow_entry *ct_entry1,
> +			      struct nfp_fl_ct_flow_entry *ct_entry2)
> +{
> +	struct nfp_fl_ct_flow_entry *post_ct_entry, *pre_ct_entry;
> +	struct nfp_fl_ct_tc_merge *m_entry;
> +	unsigned long new_cookie[2];
> +	int err;
> +
> +	if (ct_entry1->type == CT_TYPE_PRE_CT) {
> +		pre_ct_entry = ct_entry1;
> +		post_ct_entry = ct_entry2;
> +	} else {
> +		post_ct_entry = ct_entry1;
> +		pre_ct_entry = ct_entry2;
> +	}
> +
> +	if (post_ct_entry->netdev != pre_ct_entry->netdev)
> +		return -EINVAL;
> +	if (post_ct_entry->chain_index != pre_ct_entry->chain_index)
> +		return -EINVAL;

I would expect this to always fail with OVS/OVN offload, as it always
jump to a new chain after an action:ct call.

  Marcelo