netdev - Re: [PATCH V3 1/2] vDPA/ifcvf: record virtio notify base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63a73aab-964d-344f-d66b-e8e6224af687@redhat.com>
Date:   Tue, 1 Jun 2021 16:53:09 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Zhu Lingshan <lingshan.zhu@...el.com>, mst@...hat.com
Cc:     virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH V3 1/2] vDPA/ifcvf: record virtio notify base


在 2021/6/1 下午2:28, Zhu Lingshan 写道:
> This commit records virtio notify base physical addr and
> calculate doorbell physical address for vqs.
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@...el.com>


Acked-by: Jason Wang <jasowang@...hat.com>


> ---
>   drivers/vdpa/ifcvf/ifcvf_base.c | 4 ++++
>   drivers/vdpa/ifcvf/ifcvf_base.h | 2 ++
>   2 files changed, 6 insertions(+)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c
> index 1a661ab45af5..6e197fe0fcf9 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_base.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_base.c
> @@ -133,6 +133,8 @@ int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev *pdev)
>   					      &hw->notify_off_multiplier);
>   			hw->notify_bar = cap.bar;
>   			hw->notify_base = get_cap_addr(hw, &cap);
> +			hw->notify_base_pa = pci_resource_start(pdev, cap.bar) +
> +					le32_to_cpu(cap.offset);
>   			IFCVF_DBG(pdev, "hw->notify_base = %p\n",
>   				  hw->notify_base);
>   			break;
> @@ -161,6 +163,8 @@ int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev *pdev)
>   		notify_off = ifc_ioread16(&hw->common_cfg->queue_notify_off);
>   		hw->vring[i].notify_addr = hw->notify_base +
>   			notify_off * hw->notify_off_multiplier;
> +		hw->vring[i].notify_pa = hw->notify_base_pa +
> +			notify_off * hw->notify_off_multiplier;
>   	}
>   
>   	hw->lm_cfg = hw->base[IFCVF_LM_BAR];
> diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h
> index 0111bfdeb342..447f4ad9c0bf 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_base.h
> +++ b/drivers/vdpa/ifcvf/ifcvf_base.h
> @@ -73,6 +73,7 @@ struct vring_info {
>   	u16 last_avail_idx;
>   	bool ready;
>   	void __iomem *notify_addr;
> +	phys_addr_t notify_pa;
>   	u32 irq;
>   	struct vdpa_callback cb;
>   	char msix_name[256];
> @@ -87,6 +88,7 @@ struct ifcvf_hw {
>   	u8 notify_bar;
>   	/* Notificaiton bar address */
>   	void __iomem *notify_base;
> +	phys_addr_t notify_base_pa;
>   	u32 notify_off_multiplier;
>   	u64 req_features;
>   	u64 hw_features;