netdev - Re: [PATCH net-next v4 0/3] net/sched: act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLYs6UYfykZwDwJ8@dcaratti.users.ipa.redhat.com>
Date:   Tue, 1 Jun 2021 14:49:45 +0200
From:   Davide Caratti <dcaratti@...hat.com>
To:     Boris Sukholitko <boris.sukholitko@...adcom.com>
Cc:     netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        linux-kselftest@...r.kernel.org, shuah@...nel.org,
        Ilya Lifshits <ilya.lifshits@...adcom.com>,
        Shmulik Ladkani <shmulik.ladkani@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v4 0/3] net/sched: act_vlan: Fix modify to allow
 0

On Tue, Jun 01, 2021 at 03:30:49PM +0300, Boris Sukholitko wrote:
> Currently vlan modification action checks existence of vlan priority by
> comparing it to 0. Therefore it is impossible to modify existing vlan
> tag to have priority 0.

[...]
 
> Change Log:
> v3 -> v4:
> - revert tcf_vlan_get_fill_size change: total size calculation may race vs dump
> 
> v2 -> v3:
> - Push assumes that the priority is being set
> - tcf_vlan_get_fill_size accounts for priority existence
> 
> v1 -> v2:
> - Do not dump unset priority and fix tests accordingly
> - Test for priority 0 modification

Reviewed-by: Davide Caratti <dcaratti@...hat.com>