Message-ID: <20210602171655.23581-1-smalin@marvell.com>
Date:   Wed, 2 Jun 2021 20:16:48 +0300
From:   Shai Malin <smalin@...vell.com>
To:     <netdev@...r.kernel.org>, <davem@...emloft.net>, <kuba@...nel.org>
CC:     <linux-nvme@...ts.infradead.org>, <sagi@...mberg.me>, <hch@....de>,
        <axboe@...com>, <kbusch@...nel.org>, <aelior@...vell.com>,
        <mkalderon@...vell.com>, <okulkarni@...vell.com>,
        <pkushwaha@...vell.com>, <prabhakar.pkin@...il.com>,
        <malin1024@...il.com>, <smalin@...vell.com>
Subject: [PATCH 0/7] QED NVMeTCP Offload

Hi Dave,

Intro:
======
This is the qed part of Marvell’s NVMeTCP offload series, shared as 
RFC series "NVMeTCP Offload ULP and QEDN Device Drive".
This part is a standalone series, and is not dependent on other parts 
of the RFC.
The overall goal is to add qedn as the offload driver for NVMeTCP, 
alongside the existing offload drivers (qedr, qedi and qedf for rdma, 
iscsi and fcoe respectively).

In this series we are making the necessary changes to qed to enable this 
by exposing APIs for FW/HW initializations.

The qedn series (and required changes to NVMe stack) will be sent to the 
linux-nvme mailing list.
I have included more details on the upstream plan under section with the 
same name below.


The Series Patches:
===================
1. qed: Add TCP_ULP FW resource layout – replacing iSCSI when common 
   with NVMeTCP.
2. qed: Add NVMeTCP Offload PF Level FW and HW HSI.
3. qed: Add NVMeTCP Offload Connection Level FW and HW HSI.
4. qed: Add support of HW filter block – enables redirecting NVMeTCP 
   traffic to the dedicated PF.
5. qed: Add NVMeTCP Offload IO Level FW and HW HSI.
6. qed: Add NVMeTCP Offload IO Level FW Initializations.
7. qed: Add IP services APIs support –VLAN, IP routing and reserving 
   TCP ports for the offload device.


The NVMeTCP Offload:
====================
With the goal of enabling a generic infrastructure that allows NVMe/TCP
offload devices like NICs to seamlessly plug into the NVMe-oF stack, this
patch series introduces the nvme-tcp-offload ULP host layer, which will
be a new transport type called "tcp-offload" and will serve as an 
abstraction layer to work with vendor specific nvme-tcp offload drivers.

NVMeTCP offload is a full offload of the NVMeTCP protocol, this includes 
both the TCP level and the NVMeTCP level.

The nvme-tcp-offload transport can co-exist with the existing tcp and 
other transports. The tcp offload was designed so that stack changes are 
kept to a bare minimum: only registering new transports.
All other APIs, ops etc. are identical to the regular tcp transport.
Representing the TCP offload as a new transport allows clear and manageable
differentiation between the connections which should use the offload path 
and those that are not offloaded (even on the same device).

The nvme-tcp-offload layers and API compared to nvme-tcp and nvme-rdma:

* NVMe layer: *

       [ nvme/nvme-fabrics/blk-mq ]
             |
        (nvme API and blk-mq API)
             |
             |			 
* Vendor agnostic transport layer: *

      [ nvme-rdma ] [ nvme-tcp ] [ nvme-tcp-offload ]
             |        |             |
           (Verbs) 
             |        |             |
             |     (Socket)
             |        |             |
             |        |        (nvme-tcp-offload API)
             |        |             |
             |        |             |
* Vendor Specific Driver: *

             |        |             |
           [ qedr ]       
                      |             |
                   [ qede ]
                                    |
                                  [ qedn ]


Performance:
============
With this implementation on top of the Marvell qedn driver (using the
Marvell FastLinQ NIC), we were able to demonstrate the following CPU
utilization improvement:

On AMD EPYC 7402, 2.80GHz, 28 cores:
- For 16K queued read IOs, 16jobs, 4qd (50Gbps line rate): 
  Improved the CPU utilization from 15.1% with NVMeTCP SW to 4.7% with 
  NVMeTCP offload.

On Intel(R) Xeon(R) Gold 5122 CPU, 3.60GHz, 16 cores: 
- For 512K queued read IOs, 16jobs, 4qd (25Gbps line rate): 
  Improved the CPU utilization from 16.3% with NVMeTCP SW to 1.1% with 
  NVMeTCP offload.

In addition, we were able to demonstrate the following latency improvement:
- For 200K read IOPS (16 jobs, 16 qd, with fio rate limiter):
  Improved the average latency from 105 usec with NVMeTCP SW to 39 usec 
  with NVMeTCP offload.
  
  Improved the 99.99 tail latency from 570 usec with NVMeTCP SW to 91 usec 
  with NVMeTCP offload.

The end-to-end offload latency was measured from fio while running against 
back end of null device.


The Marvell FastLinQ NIC HW engine:
====================================
The Marvell NIC HW engine is capable of offloading the entire TCP/IP
stack and managing up to 64K connections per PF, already implemented and 
upstream use cases for this include iWARP (by the Marvell qedr driver) 
and iSCSI (by the Marvell qedi driver).
In addition, the Marvell NIC HW engine offloads the NVMeTCP queue layer
and is able to manage the IO level also in case of TCP re-transmissions
and OOO events.
The HW engine enables direct data placement (including the data digest CRC
calculation and validation) and direct data transmission (including data
digest CRC calculation).


The Marvell qedn driver:
========================
The new driver will be added under "drivers/nvme/hw" and will be enabled
by the Kconfig "Marvell NVM Express over Fabrics TCP offload".
As part of the qedn init, the driver will register as a pci device driver 
and will work with the Marvell fastlinQ NIC.
As part of the probe, the driver will register to the nvme_tcp_offload
(ULP) and to the qed module (qed_nvmetcp_ops) - similar to other
"qed_*_ops" which are used by the qede, qedr, qedf and qedi device
drivers.


Upstream Plan:
=============
The RFC series "NVMeTCP Offload ULP and QEDN Device Driver" 
https://lore.kernel.org/netdev/20210531225222.16992-1-smalin@marvell.com/
was designed in a modular way so that part 1 (nvme-tcp-offload) and 
part 2 (qed) are independent and part 3 (qedn) depends on both parts 1+2.

- Part 1 (RFC patch 1-8): NVMeTCP Offload ULP
  The nvme-tcp-offload patches, will be sent to 
  'linux-nvme@...ts.infradead.org'.
  
- Part 2 (RFC patches 9-15): QED NVMeTCP Offload
  The qed infrastructure, will be sent to 'netdev@...r.kernel.org'.

Once part 1 and 2 are accepted:

- Part 3 (RFC patches 16-27): QEDN NVMeTCP Offload
  The qedn patches, will be sent to 'linux-nvme@...ts.infradead.org'.


Changes since RFC v1,2:
=====================
- No changes in qed (only in nvme-tcp-offload and qedn).

Changes since RFC v3:
=====================
- qed: Add support for the new AHP HW. 

Changes since RFC v4:
=====================
(Many thanks to Hannes Reinecke for his feedback)
- qed: Add TCP_ULP FW resource layout.
- qed: Fix ipv4/ipv6 address initialization.
- qed: Replace structures with nvme-tcp.h structures.

Changes since RFC v5,6:
=====================
- No changes in qed (only in nvme-tcp-offload and qedn).


Nikolay Assa (1):
  qed: Add IP services APIs support

Omkar Kulkarni (1):
  qed: Add TCP_ULP FW resource layout

Prabhakar Kushwaha (1):
  qed: Add support of HW filter block

Shai Malin (4):
  qed: Add NVMeTCP Offload PF Level FW and HW HSI
  qed: Add NVMeTCP Offload Connection Level FW and HW HSI
  qed: Add NVMeTCP Offload IO Level FW and HW HSI
  qed: Add NVMeTCP Offload IO Level FW Initializations

 drivers/net/ethernet/qlogic/Kconfig           |   3 +
 drivers/net/ethernet/qlogic/qed/Makefile      |   5 +
 drivers/net/ethernet/qlogic/qed/qed.h         |  14 +
 drivers/net/ethernet/qlogic/qed/qed_cxt.c     |  45 +-
 drivers/net/ethernet/qlogic/qed/qed_cxt.h     |   2 +-
 drivers/net/ethernet/qlogic/qed/qed_dev.c     | 140 ++-
 drivers/net/ethernet/qlogic/qed/qed_hsi.h     |   6 +-
 drivers/net/ethernet/qlogic/qed/qed_iscsi.c   |  20 +-
 drivers/net/ethernet/qlogic/qed/qed_ll2.c     |  40 +-
 drivers/net/ethernet/qlogic/qed/qed_mcp.c     |   3 +
 drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c |   3 +-
 drivers/net/ethernet/qlogic/qed/qed_nvmetcp.c | 829 ++++++++++++++++++
 drivers/net/ethernet/qlogic/qed/qed_nvmetcp.h | 103 +++
 .../qlogic/qed/qed_nvmetcp_fw_funcs.c         | 376 ++++++++
 .../qlogic/qed/qed_nvmetcp_fw_funcs.h         |  40 +
 .../qlogic/qed/qed_nvmetcp_ip_services.c      | 238 +++++
 drivers/net/ethernet/qlogic/qed/qed_ooo.c     |   5 +-
 drivers/net/ethernet/qlogic/qed/qed_sp.h      |   5 +
 .../net/ethernet/qlogic/qed/qed_sp_commands.c |   3 +-
 include/linux/qed/common_hsi.h                |   2 +-
 include/linux/qed/nvmetcp_common.h            | 531 +++++++++++
 include/linux/qed/qed_if.h                    |  18 +
 include/linux/qed/qed_ll2_if.h                |   2 +-
 include/linux/qed/qed_nvmetcp_if.h            | 240 +++++
 .../linux/qed/qed_nvmetcp_ip_services_if.h    |  29 +
 25 files changed, 2650 insertions(+), 52 deletions(-)
 create mode 100644 drivers/net/ethernet/qlogic/qed/qed_nvmetcp.c
 create mode 100644 drivers/net/ethernet/qlogic/qed/qed_nvmetcp.h
 create mode 100644 drivers/net/ethernet/qlogic/qed/qed_nvmetcp_fw_funcs.c
 create mode 100644 drivers/net/ethernet/qlogic/qed/qed_nvmetcp_fw_funcs.h
 create mode 100644 drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c
 create mode 100644 include/linux/qed/nvmetcp_common.h
 create mode 100644 include/linux/qed/qed_nvmetcp_if.h
 create mode 100644 include/linux/qed/qed_nvmetcp_ip_services_if.h

-- 
2.22.0

Powered by blists - more mailing lists