netdev - Re: [PATCH v2 1/8] Bluetooth: use inclusive language in HCI role

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <AF991D82-2984-450B-A522-54F8F4E850F8@holtmann.org>
Date:   Wed, 2 Jun 2021 21:55:20 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Archie Pusaka <apusaka@...gle.com>
Cc:     linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@...omium.org>,
        Archie Pusaka <apusaka@...omium.org>,
        Miao-chen Chou <mcchou@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        open list <linux-kernel@...r.kernel.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/8] Bluetooth: use inclusive language in HCI role

Hi Archie,

> This patch replaces some non-inclusive terms based on the appropriate
> language mapping table compiled by the Bluetooth SIG:
> https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
> 
> Specifically, these terms are replaced:
> master -> central
> slave  -> peripheral
> 
> Signed-off-by: Archie Pusaka <apusaka@...omium.org>
> Reviewed-by: Miao-chen Chou <mcchou@...omium.org>
> 
> ---
> 
> Changes in v2:
> * Add details in commit message
> 
> include/net/bluetooth/hci.h      |  6 +++---
> include/net/bluetooth/hci_core.h |  4 ++--
> net/bluetooth/amp.c              |  2 +-
> net/bluetooth/hci_conn.c         | 30 +++++++++++++++---------------
> net/bluetooth/hci_core.c         |  6 +++---
> net/bluetooth/hci_event.c        | 20 ++++++++++----------
> net/bluetooth/l2cap_core.c       | 12 ++++++------
> net/bluetooth/smp.c              | 20 ++++++++++----------
> 8 files changed, 50 insertions(+), 50 deletions(-)
> 
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index c4b0650fb9ae..18742f4471ff 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -515,7 +515,7 @@ enum {
> 
> /* Link modes */
> #define HCI_LM_ACCEPT	0x8000
> -#define HCI_LM_MASTER	0x0001
> +#define HCI_LM_CENTRAL	0x0001
> #define HCI_LM_AUTH	0x0002
> #define HCI_LM_ENCRYPT	0x0004
> #define HCI_LM_TRUSTED	0x0008

this is my fault since I overlooked this one. This is also API. Lets skip this for now.

Regards

Marcel