netdev - Re: [PATCH v2 00/12] net/Bluetooth: correct the use of print format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <29FB1C65-7FA6-4110-B953-5281C0587CAF@holtmann.org>
Date:   Wed, 2 Jun 2021 22:18:01 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Kai Ye <yekai13@...wei.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 00/12] net/Bluetooth: correct the use of print format

Hi Kai,

> According to Documentation/core-api/printk-formats.rst,
> Use the correct print format. 
> 1. Printing an unsigned int value should use %u instead of %d.
> 2. Printing an unsigned long value should use %lu instead of %ld.
> Otherwise printk() might end up displaying negative numbers.
> 
> changes v1 -> v2:
> 	fix some style problems
> 
> Kai Ye (12):
>  net/Bluetooth/bnep - use the correct print format
>  net/Bluetooth/cmtp - use the correct print format
>  net/Bluetooth/hidp - use the correct print format
>  net/Bluetooth/rfcomm - use the correct print format
>  net/Bluetooth/6lowpan - use the correct print format
>  net/Bluetooth/a2mp - use the correct print format
>  net/Bluetooth/amp - use the correct print format
>  net/Bluetooth/hci - use the correct print format
>  net/Bluetooth/mgmt - use the correct print format
>  net/Bluetooth/msft - use the correct print format
>  net/Bluetooth/sco - use the correct print format
>  net/Bluetooth/smp - use the correct print format

please fix the commit message to apply with expected style. Fixing up 12 patches manually is not something I am going to do.

Regards

Marcel