netdev - RE: [PATCH net v4] igb: Fix XDP with PTP enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW3PR11MB4554208E081D4DD08EADD7669C3C9@MW3PR11MB4554.namprd11.prod.outlook.com>
Date:   Thu, 3 Jun 2021 11:30:44 +0000
From:   "Penigalapati, Sandeep" <sandeep.penigalapati@...el.com>
To:     Kurt Kanzenbach <kurt@...utronix.de>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        "John Fastabend" <john.fastabend@...il.com>,
        Sven Auhagen <sven.auhagen@...eatech.de>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "Ilias Apalodimas" <ilias.apalodimas@...aro.org>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Richard Cochran <richardcochran@...il.com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Tyler S <tylerjstachecki@...il.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>
Subject: RE: [PATCH net v4] igb: Fix XDP with PTP enabled

>-----Original Message-----
>From: Kurt Kanzenbach <kurt@...utronix.de>
>Sent: Monday, May 3, 2021 12:58 PM
>To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
><anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>;
>Jakub Kicinski <kuba@...nel.org>
>Cc: Alexei Starovoitov <ast@...nel.org>; Daniel Borkmann
><daniel@...earbox.net>; Jesper Dangaard Brouer <hawk@...nel.org>; John
>Fastabend <john.fastabend@...il.com>; Sven Auhagen
><sven.auhagen@...eatech.de>; intel-wired-lan@...ts.osuosl.org;
>netdev@...r.kernel.org; bpf@...r.kernel.org; Ilias Apalodimas
><ilias.apalodimas@...aro.org>; Lorenzo Bianconi <lorenzo@...nel.org>;
>Sebastian Andrzej Siewior <bigeasy@...utronix.de>; Richard Cochran
><richardcochran@...il.com>; Alexander Duyck
><alexander.duyck@...il.com>; Tyler S <tylerjstachecki@...il.com>;
>Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; Kurt Kanzenbach
><kurt@...utronix.de>
>Subject: [PATCH net v4] igb: Fix XDP with PTP enabled
>
>When using native XDP with the igb driver, the XDP frame data doesn't point
>to the beginning of the packet. It's off by 16 bytes. Everything works as
>expected with XDP skb mode.
>
>Actually these 16 bytes are used to store the packet timestamps. Therefore,
>pull the timestamp before executing any XDP operations and adjust all other
>code accordingly. The igc driver does it like that as well.
>
>Tested with Intel i210 card and AF_XDP sockets.
>
>Fixes: 9cbc948b5a20 ("igb: add XDP support")
>Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
>---
>
>Changes since v3:
>
> * Get rid of timestamp check in hot path (Maciej Fijalkowski)
>
>Changes since v2:
>
> * Check timestamp for validity (Nguyen, Anthony L)
>
>Changes since v1:
>
> * Use xdp_prepare_buff() (Lorenzo Bianconi)
>
>Changes since RFC:
>
> * Removed unused return value definitions (Alexander Duyck)
>
>Previous versions:
>
> * https://lkml.kernel.org/netdev/20210422052617.17267-1-
>kurt@...utronix.de/
> * https://lkml.kernel.org/netdev/20210419072332.7246-1-
>kurt@...utronix.de/
> * https://lkml.kernel.org/netdev/20210415092145.27322-1-
>kurt@...utronix.de/
> * https://lkml.kernel.org/netdev/20210412101713.15161-1-
>kurt@...utronix.de/
>
> drivers/net/ethernet/intel/igb/igb.h      |  2 +-
> drivers/net/ethernet/intel/igb/igb_main.c | 45 +++++++++++++----------
>drivers/net/ethernet/intel/igb/igb_ptp.c  | 23 +++++-------
> 3 files changed, 37 insertions(+), 33 deletions(-)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@...el.com>