netdev - Re: [PATCH] ipv6: parameter p.name is empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c9bcc89-0ec7-0588-719e-d63b36bef132@6wind.com>
Date:   Thu, 3 Jun 2021 18:29:40 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     David Ahern <dsahern@...il.com>, zhang kai <zhangkaiheb@....com>,
        davem@...emloft.net, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv6: parameter p.name is empty

Le 03/06/2021 à 17:15, David Ahern a écrit :
> On 6/3/21 7:33 AM, Nicolas Dichtel wrote:
>> Le 03/06/2021 à 11:50, zhang kai a écrit :
>>> so do not check it.
>>>
>>> Signed-off-by: zhang kai <zhangkaiheb@....com>
>>> ---
>>>  net/ipv6/addrconf.c | 3 ---
>>>  1 file changed, 3 deletions(-)
>>>
>>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
>>> index b0ef65eb9..4c6b3fc7e 100644
>>> --- a/net/ipv6/addrconf.c
>>> +++ b/net/ipv6/addrconf.c
>>> @@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev,
>>>  	if (err)
>>>  		return err;
>>>  
>>> -	dev = __dev_get_by_name(net, p.name);
>>> -	if (!dev)
>>> -		return -ENOBUFS;
>>>  	return dev_open(dev, NULL);
>>>  }
>>>  
>>>
>> This bug seems to exist since the beginning of the SIT driver (24 years!):
>> https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a
>> Search addrconf_set_dstaddr()
>>
>> Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>>
> 
> A patch was sent yesterday, "sit: set name of device back to struct
> parms", to set the name field in params.
> 
Oh yes, it was in my spam folder ...