netdev - Re: [PATCH net-next] ieee802154: fix error return code in ieee802154_llsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8700eed-1791-fd55-4568-dc4efeda35eb@datenfreihafen.org>
Date:   Thu, 3 Jun 2021 11:01:51 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Alexander Aring <alex.aring@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH net-next] ieee802154: fix error return code in
 ieee802154_llsec_getparams()

Hello.

On 19.05.21 16:16, Wei Yongjun wrote:
> Fix to return negative error code -ENOBUFS from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>   net/ieee802154/nl-mac.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ieee802154/nl-mac.c b/net/ieee802154/nl-mac.c
> index 0c1b0770c59e..c23c152860b7 100644
> --- a/net/ieee802154/nl-mac.c
> +++ b/net/ieee802154/nl-mac.c
> @@ -680,8 +680,10 @@ int ieee802154_llsec_getparams(struct sk_buff *skb, struct genl_info *info)
>   	    nla_put_u8(msg, IEEE802154_ATTR_LLSEC_SECLEVEL, params.out_level) ||
>   	    nla_put_u32(msg, IEEE802154_ATTR_LLSEC_FRAME_COUNTER,
>   			be32_to_cpu(params.frame_counter)) ||
> -	    ieee802154_llsec_fill_key_id(msg, &params.out_key))
> +	    ieee802154_llsec_fill_key_id(msg, &params.out_key)) {
> +		rc = -ENOBUFS;
>   		goto out_free;
> +	}
>   
>   	dev_put(dev);


This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt