netdev - Re: [PATCH v2 1/1] b43: phy_n: Delete some useless TODO code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210603093103.73322C433D3@smtp.codeaurora.org>
Date:   Thu,  3 Jun 2021 09:31:03 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        b43-dev <b43-dev@...ts.infradead.org>,
        netdev <netdev@...r.kernel.org>,
        Zhen Lei <thunder.leizhen@...wei.com>
Subject: Re: [PATCH v2 1/1] b43: phy_n: Delete some useless TODO code

Zhen Lei <thunder.leizhen@...wei.com> wrote:

> These TODO empty code are added by
> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
> been more than a decade now. I don't think anyone who wants to perfect
> this workaround can follow this TODO tip exactly. Instead, it limits them
> to new thinking. Remove it will be better.
> 
> No functional change.
> 
> By the way, this helps reduce some binary code size.
> Before:
> text    data    bss     dec     hex
> 74472   9967    0       84439   149d7
> 
> After:
> text    data    bss     dec     hex
> 74408   9919    0       84327   14967
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Patch applied to wireless-drivers-next.git, thanks.

da16f5be45d0 b43: phy_n: Delete some useless TODO code

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210511034203.4122-2-thunder.leizhen@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches