netdev - Re: [PATCH 1/2] net:cxgb3: replace tasklets with works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 4 Jun 2021 13:19:23 +0200
From:   Íñigo Huguet <ihuguet@...hat.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     rajur@...lsio.com, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ivan Vecera <ivecera@...hat.com>
Subject: Re: [PATCH 1/2] net:cxgb3: replace tasklets with works

On Fri, Jun 4, 2021 at 5:15 AM Hillf Danton <hdanton@...a.com> wrote:
> Good material to be shoehorned into commit message though without sheding
> any light first on the reasons why CTRL is so special its work wont bother
> being canceled.

Not sure what you mean. If it's that CTRL work isn't being cancelled,
but OFLD is being cancelled twice, thanks for pointing it. I'm sending
a new patch.

> How long? Long enough for the kworker to become a CPU hog?
> What is it in your opinion to cut the chance for that risk?

I don't think so, not by its own, but the maybe yes the sum of many
tasks in softirq context (it will depend on what else is being
executed in the system). As far as I know, moving work from softirq to
threads to reduce latencies is seen as a good thing, unless it's
really necessary.
-- 
Íñigo Huguet