netdev - Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Jun 2021 18:37:26 +0000
From:   Liang Xu <lxu@...linear.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "vee.khee.wong@...ux.intel.com" <vee.khee.wong@...ux.intel.com>
CC:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        Hauke Mehrtens <hmehrtens@...linear.com>,
        Thomas Mohren <tmohren@...linear.com>
Subject: Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver

On 5/6/2021 12:24 am, Florian Fainelli wrote:
>
> > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> > index 288bf405ebdb..d02098774d80 100644
> > --- a/drivers/net/phy/Kconfig
> > +++ b/drivers/net/phy/Kconfig
> > @@ -207,6 +207,12 @@ config MARVELL_88X2222_PHY
> > Support for the Marvell 88X2222 Dual-port Multi-speed Ethernet
> > Transceiver.
> >
> > +config MXL_GPHY
> > + tristate "Maxlinear PHYs"
> > + help
> > + Support for the Maxlinear GPY115, GPY211, GPY212, GPY215,
> > + GPY241, GPY245 PHYs.
> > +
> > config MICREL_PHY
> > tristate "Micrel PHYs"
> > help
> > diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
> > index bcda7ed2455d..1055fb73ac17 100644
> > --- a/drivers/net/phy/Makefile
> > +++ b/drivers/net/phy/Makefile
> > @@ -70,6 +70,7 @@ obj-$(CONFIG_MICREL_PHY) += micrel.o
> > obj-$(CONFIG_MICROCHIP_PHY) += microchip.o
> > obj-$(CONFIG_MICROCHIP_T1_PHY) += microchip_t1.o
> > obj-$(CONFIG_MICROSEMI_PHY) += mscc/
> > +obj-$(CONFIG_MXL_GPHY) += mxl-gpy.o
>
> Could you spell it out completely: CONFIG_MAXLINEAR_GPHY for consistency
> with the other vendor's and also to have some proper namespacing in case
> we see a non-Ethernet PHY being submitted for a Maxlinear product in the
> future?

I will fix in v4 patch.

Thank you.