netdev - Re: [PATCH 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 5 Jun 2021 02:56:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Łukasz Stelmach <l.stelmach@...sung.com>,
        Andrew Lunn <andrew@...n.ch>, jim.cromie@...il.com,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Russell King <linux@...linux.org.uk>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter
 Driver

Hi "Łukasz,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on net-next/master net/master linus/master v5.13-rc4 next-20210604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/ukasz-Stelmach/dt-bindings-vendor-prefixes-Add-asix-prefix/20210604-190236
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/513c0bd47d3362c2332cd0b4ff5956902f58c1e5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review ukasz-Stelmach/dt-bindings-vendor-prefixes-Add-asix-prefix/20210604-190236
        git checkout 513c0bd47d3362c2332cd0b4ff5956902f58c1e5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/byteorder/big_endian.h:5,
                    from arch/mips/include/uapi/asm/byteorder.h:13,
                    from include/asm-generic/qrwlock_types.h:6,
                    from arch/mips/include/asm/spinlock_types.h:6,
                    from include/linux/spinlock_types.h:13,
                    from include/linux/ratelimit_types.h:7,
                    from include/linux/ratelimit.h:5,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/spi/spi.h:10,
                    from drivers/net/ethernet/asix/ax88796c_spi.c:12:
   drivers/net/ethernet/asix/ax88796c_spi.c: In function 'axspi_read_reg':
>> drivers/net/ethernet/asix/ax88796c_spi.c:95:21: error: passing argument 1 of '__swab16s' from incompatible pointer type [-Werror=incompatible-pointer-types]
      95 |  le16_to_cpus(ax_spi->rx_buf);
   include/uapi/linux/byteorder/big_endian.h:97:38: note: in definition of macro '__le16_to_cpus'
      97 | #define __le16_to_cpus(x) __swab16s((x))
         |                                      ^
   drivers/net/ethernet/asix/ax88796c_spi.c:95:2: note: in expansion of macro 'le16_to_cpus'
      95 |  le16_to_cpus(ax_spi->rx_buf);
         |  ^~~~~~~~~~~~
   In file included from include/linux/swab.h:5,
                    from include/uapi/linux/byteorder/big_endian.h:13,
                    from include/linux/byteorder/big_endian.h:5,
                    from arch/mips/include/uapi/asm/byteorder.h:13,
                    from include/asm-generic/qrwlock_types.h:6,
                    from arch/mips/include/asm/spinlock_types.h:6,
                    from include/linux/spinlock_types.h:13,
                    from include/linux/ratelimit_types.h:7,
                    from include/linux/ratelimit.h:5,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/spi/spi.h:10,
                    from drivers/net/ethernet/asix/ax88796c_spi.c:12:
   include/uapi/linux/swab.h:240:37: note: expected '__u16 *' {aka 'short unsigned int *'} but argument is of type 'u8 *' {aka 'unsigned char *'}
     240 | static inline void __swab16s(__u16 *p)
         |                              ~~~~~~~^
   cc1: some warnings being treated as errors


vim +/__swab16s +95 drivers/net/ethernet/asix/ax88796c_spi.c

    76	
    77	u16 axspi_read_reg(struct axspi_data *ax_spi, u8 reg)
    78	{
    79		int ret;
    80		int len = ax_spi->comp ? 3 : 4;
    81	
    82		ax_spi->cmd_buf[0] = 0x03;	/* OP code read register */
    83		ax_spi->cmd_buf[1] = reg;	/* register address */
    84		ax_spi->cmd_buf[2] = 0xFF;	/* dumy cycle */
    85		ax_spi->cmd_buf[3] = 0xFF;	/* dumy cycle */
    86		ret = spi_write_then_read(ax_spi->spi,
    87					  ax_spi->cmd_buf, len,
    88					  ax_spi->rx_buf, 2);
    89		if (ret) {
    90			dev_err(&ax_spi->spi->dev,
    91				"%s() failed: ret = %d\n", __func__, ret);
    92			return 0xFFFF;
    93		}
    94	
  > 95		le16_to_cpus(ax_spi->rx_buf);
    96	
    97		return *(u16 *)ax_spi->rx_buf;
    98	}
    99	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (71035 bytes)