netdev - RE: Unsupported phy-connection-type sgmii-2500 in arch/powerpc/boot/dts/fsl/t1023rdb.dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB39760B986E86BA9169DEECC5EC3B9@AM6PR04MB3976.eurprd04.prod.outlook.com>
Date:   Fri, 4 Jun 2021 21:47:26 +0000
From:   Madalin Bucur <madalin.bucur@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Russell King <linux@...linux.org.uk>,
        Pali Rohár <pali@...nel.org>,
        Igal Liberman <Igal.Liberman@...escale.com>,
        Shruti Kanetkar <Shruti@...escale.com>,
        Emil Medve <Emilian.Medve@...escale.com>,
        Scott Wood <oss@...error.net>,
        Rob Herring <robh+dt@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Camelia Alexandra Groza (OSS)" <camelia.groza@....nxp.com>
Subject: RE: Unsupported phy-connection-type sgmii-2500 in
 arch/powerpc/boot/dts/fsl/t1023rdb.dts

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: 04 June 2021 23:24
> To: Madalin Bucur <madalin.bucur@....com>
> Cc: Russell King <linux@...linux.org.uk>; Pali Rohár <pali@...nel.org>;
> Igal Liberman <Igal.Liberman@...escale.com>; Shruti Kanetkar
> <Shruti@...escale.com>; Emil Medve <Emilian.Medve@...escale.com>; Scott
> Wood <oss@...error.net>; Rob Herring <robh+dt@...nel.org>; Michael
> Ellerman <mpe@...erman.id.au>; Benjamin Herrenschmidt
> <benh@...nel.crashing.org>; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Camelia
> Alexandra Groza (OSS) <camelia.groza@....nxp.com>
> Subject: Re: Unsupported phy-connection-type sgmii-2500 in
> arch/powerpc/boot/dts/fsl/t1023rdb.dts
> 
> > The "sgmii-2500" compatible in that device tree describes an SGMII HW
> > block, overclocked at 2.5G. Without that overclocking, it's a plain
> > Cisco (like) SGMII HW block. That's the reason you need to disable it's
> > AN setting when overclocked. With the proper Reset Configuration Word,
> > you could remove the overclocking and transform that into a plain
> "sgmii".
> > Thus, the dts compatible describes the HW, as it is.
> 
> It sounds like the hardware is capable of swapping between SGMII and
> 2500BaseX.
> 
> What we have in DT in this case is not describing the hardware, but
> how we configure the hardware. It is one of the few places we abuse DT
> for configuration.
> 
>     Andrew

The actual selection of this mode of operation is performed by the so called
Reset Configuration Word from the boot media, that aligned with the HW and
board design. The need to name it something other than plain "sgmii" comes
from the HW special need for AN to be disabled to operate.

Actually, the weird/non-standard hardware is described by the device tree
with a value that puts it in a class of its own. Instead of the overclocked
SGMII denomination "sgmii-2500" it could have been named just as well
"overclocked-nonstandard-2.5G-ethernet-no-autoneg-SGMII-hw-ip".

One could try to change device trees to slip configuration details, but the
backwards compatibility aspect renders this futile. Is there any option to
say "sgmii" then "autoneg disabled"?

Madalin