netdev - Re: [PATCH net] sch_htb: fix refcount leak in htb_parent_to_leaf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162284340414.5449.12585313149011194303.git-patchwork-notify@kernel.org>
Date:   Fri, 04 Jun 2021 21:50:04 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     wangyunjian <wangyunjian@...wei.com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        maximmi@...dia.com, tariqt@...dia.com, xiyou.wangcong@...il.com,
        jhs@...atatu.com, dingxiaoxiong@...wei.com
Subject: Re: [PATCH net] sch_htb: fix refcount leak in htb_parent_to_leaf_offload

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 4 Jun 2021 19:03:18 +0800 you wrote:
> From: Yunjian Wang <wangyunjian@...wei.com>
> 
> The commit ae81feb7338c ("sch_htb: fix null pointer dereference
> on a null new_q") fixes a NULL pointer dereference bug, but it
> is not correct.
> 
> Because htb_graft_helper properly handles the case when new_q
> is NULL, and after the previous patch by skipping this call
> which creates an inconsistency : dev_queue->qdisc will still
> point to the old qdisc, but cl->parent->leaf.q will point to
> the new one (which will be noop_qdisc, because new_q was NULL).
> The code is based on an assumption that these two pointers are
> the same, so it can lead to refcount leaks.
> 
> [...]

Here is the summary with links:
  - [net] sch_htb: fix refcount leak in htb_parent_to_leaf_offload
    https://git.kernel.org/netdev/net/c/944d671d5faa

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html