netdev - Re: [PATCH next-queue v4 2/4] PCI: Add pcie_ptm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210604222712.GA2246328@bjorn-Precision-5520>
Date:   Fri, 4 Jun 2021 17:27:12 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Cc:     intel-wired-lan@...ts.osuosl.org, sasha.neftin@...el.com,
        anthony.l.nguyen@...el.com, linux-pci@...r.kernel.org,
        bhelgaas@...gle.com, netdev@...r.kernel.org, mlichvar@...hat.com,
        richardcochran@...il.com, hch@...radead.org
Subject: Re: [PATCH next-queue v4 2/4] PCI: Add pcie_ptm_enabled()

On Fri, Jun 04, 2021 at 03:09:31PM -0700, Vinicius Costa Gomes wrote:
> Adds a predicate that returns if PCIe PTM (Precision Time Measurement)
> is enabled.

Ideally, "Add a predicate ..."

> It will only return true if it's enabled in all the ports in the path
> from the device to the root.
> 
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>

But either way,

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

> ---
>  drivers/pci/pcie/ptm.c | 9 +++++++++
>  include/linux/pci.h    | 3 +++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/pci/pcie/ptm.c b/drivers/pci/pcie/ptm.c
> index 95d4eef2c9e8..8a4ad974c5ac 100644
> --- a/drivers/pci/pcie/ptm.c
> +++ b/drivers/pci/pcie/ptm.c
> @@ -204,3 +204,12 @@ int pci_enable_ptm(struct pci_dev *dev, u8 *granularity)
>  	return 0;
>  }
>  EXPORT_SYMBOL(pci_enable_ptm);
> +
> +bool pcie_ptm_enabled(struct pci_dev *dev)
> +{
> +	if (!dev)
> +		return false;
> +
> +	return dev->ptm_enabled;
> +}
> +EXPORT_SYMBOL(pcie_ptm_enabled);
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index a687dda262dd..fe7f264b2b15 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1619,9 +1619,12 @@ bool pci_ats_disabled(void);
>  
>  #ifdef CONFIG_PCIE_PTM
>  int pci_enable_ptm(struct pci_dev *dev, u8 *granularity);
> +bool pcie_ptm_enabled(struct pci_dev *dev);
>  #else
>  static inline int pci_enable_ptm(struct pci_dev *dev, u8 *granularity)
>  { return -EINVAL; }
> +static inline bool pcie_ptm_enabled(struct pci_dev *dev)
> +{ return false; }
>  #endif
>  
>  void pci_cfg_access_lock(struct pci_dev *dev);
> -- 
> 2.31.1
>