lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Jun 2021 10:10:27 +0300 From: Dmytro Linkin <dlinkin@...dia.com> To: Colin King <colin.king@...onical.com>, Jakub Kicinski <kuba@...nel.org>, "David S . Miller" <davem@...emloft.net>, Yuval Avnery <yuvalav@...dia.com>, Jiri Pirko <jiri@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH][next] netdevsim: Fix unsigned being compared to less than zero On 6/4/21 12:56 AM, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > The comparison of len < 0 is always false because len is a size_t. Fix > this by making len a ssize_t instead. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: d395381909a3 ("netdevsim: Add max_vfs to bus_dev") > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > drivers/net/netdevsim/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c > index b56003dfe3cc..ccec29970d5b 100644 > --- a/drivers/net/netdevsim/bus.c > +++ b/drivers/net/netdevsim/bus.c > @@ -111,7 +111,7 @@ ssize_t nsim_bus_dev_max_vfs_read(struct file *file, > { > struct nsim_bus_dev *nsim_bus_dev = file->private_data; > char buf[11]; > - size_t len; > + ssize_t len; > > len = snprintf(buf, sizeof(buf), "%u\n", nsim_bus_dev->max_vfs); > if (len < 0) > Thanks.
Powered by blists - more mailing lists