netdev - Re: [RESEND PATCH net v3 0/3] Fix IPsec crypto offloads with vxlan tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Jun 2021 09:57:30 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Huy Nguyen <huyn@...dia.com>
CC:     <netdev@...r.kernel.org>, <saeedm@...dia.com>, <borisp@...dia.com>,
        <raeds@...dia.com>, <danielj@...dia.com>, <yossiku@...dia.com>,
        <kuba@...nel.org>
Subject: Re: [RESEND PATCH net v3 0/3] Fix IPsec crypto offloads with vxlan
 tunnel

On Thu, Jun 03, 2021 at 07:00:42PM +0300, Huy Nguyen wrote:
> v1 -> v2:
>   - Move inner_ipproto into xfrm_offload structure.
>   - Fix static code analysis errors.
>   - skip checking for skb->encapsulation to be more flexible for vendor
> 
> v2 -> v3:
>   - Fix bug in patch 003 when checking for xo null pointer in mlx5e_ipsec_feature_check
>   - Fix bug of accidentally commenting out memset in patch 003
> 
> This small series fixes ipsec TX offloads with vxlan overlay on top of
> the offloaded ipsec packet, the driver (mlx5) was lacking such information
> and the skb->encapsulation bit wasn't enough as indication to reach the
> vxlan inner headers, as a solution we mark the tunnel in the offloaded
> context of ipsec.

This patchset does not look like a fix. It looks more that you add
a feature that was not supported before, so the pachset should
go to -next.

Also, who should merge that pachset? I contains xfrm and mlx5
parts.