netdev - Re: [Intel-wired-lan] [PATCH next-queue v4 1/4] Revert "PCI: Make pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61fbd916-ca4e-26b0-5d18-a2b2aa075a7f@molgen.mpg.de>
Date:   Sat, 5 Jun 2021 07:47:23 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     netdev@...r.kernel.org, richardcochran@...il.com,
        hch@...radead.org, linux-pci@...r.kernel.org, bhelgaas@...gle.com,
        intel-wired-lan@...ts.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH next-queue v4 1/4] Revert "PCI: Make
 pci_enable_ptm() private"

Dear Vinicius, dear Bjorn,


Am 05.06.21 um 01:27 schrieb Vinicius Costa Gomes:
> Bjorn Helgaas <helgaas@...nel.org> writes:
> 
>> On Fri, Jun 04, 2021 at 03:09:30PM -0700, Vinicius Costa Gomes wrote:

[…]

>>> Exposing this to the driver enables the driver to use the
>>> 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not.
>>>
>>> This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c.
>>
>> Ideally I would cite this as ac6c26da29c1 ("PCI: Make pci_enable_ptm()
>> private") so there's a little more context.
> 
> Yeah, that looks better.
> 
> Will follow the suggestions you made in the next patch as well and send
> another version, thanks.

Just a note, that this is how revert commits are generated by `git 
revert` as the name of the reverted commit is in the commit message 
summary. Maybe just move the statement/sentence to the very top? But 
either way is fine.


Kind regards,

Paul