netdev - RE: [Intel-wired-lan] [PATCH v2 intel-net 2/2] ice: parametrize functions responsible for Tx ring management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Jun 2021 15:32:09 +0000
From:   "Bhandare, KiranX" <kiranx.bhandare@...el.com>
To:     "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bjorn@...nel.org" <bjorn@...nel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v2 intel-net 2/2] ice: parametrize
 functions responsible for Tx ring management

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Maciej Fijalkowski
> Sent: Thursday, May 20, 2021 12:05 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; bjorn@...nel.org; kuba@...nel.org;
> bpf@...r.kernel.org; davem@...emloft.net; Karlsson, Magnus
> <magnus.karlsson@...el.com>
> Subject: [Intel-wired-lan] [PATCH v2 intel-net 2/2] ice: parametrize functions
> responsible for Tx ring management
> 
> Commit ae15e0ba1b33 ("ice: Change number of XDP Tx queues to match
> number of Rx queues") tried to address the incorrect setting of XDP queue
> count that was based on the Tx queue count, whereas in theory we should
> provide the XDP queue per Rx queue. However, the routines that setup and
> destroy the set of Tx resources are still based on the
> vsi->num_txq.
> 
> Ice supports the asynchronous Tx/Rx queue count, so for a setup where
> vsi->num_txq > vsi->num_rxq, ice_vsi_stop_tx_rings and ice_vsi_cfg_txqs
> will be accessing the vsi->xdp_rings out of the bounds.
> 
> Parametrize two mentioned functions so they get the size of Tx resources
> array as the input.
> 
> Fixes: ae15e0ba1b33 ("ice: Change number of XDP Tx queues to match
> number of Rx queues")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 

Tested-by: Kiran Bhandare <kiranx.bhandare@...el.com>  A Contingent Worker at Intel