netdev - Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Jun 2021 04:06:42 +0000
From:   Liang Xu <lxu@...linear.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Florian Fainelli <f.fainelli@...il.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "vee.khee.wong@...ux.intel.com" <vee.khee.wong@...ux.intel.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        Hauke Mehrtens <hmehrtens@...linear.com>,
        Thomas Mohren <tmohren@...linear.com>
Subject: Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver

On 5/6/2021 10:51 pm, Andrew Lunn wrote:
> This email was sent from outside of MaxLinear.
>
>
>>>>> This does not access vendor specific registers, should not this be part
>>>>> of the standard genphy_read_abilities() or moved to a helper?
>>>>>
>>>> genphy_read_abilities does not cover 2.5G.
>>>>
>>>> genphy_c45_pma_read_abilities checks C45 ids and this check fail if
>>>> is_c45 is not set.
>>> You appear to of ignored my comment about this. Please add the helper
>>> to the core as i suggested, and then use
>>> genphy_c45_pma_read_abilities().
>>>
>>>           Andrew
>>>
>> I'm new to upstream and do not know the process to change code in core.
> Pretty much the same way you change code in a driver. Submit a path!
>
> Please put it into a separate patch, so making a patch series. Please
> add some kernel doc style documentation, describing what the function
> does. Look at other functions in phy_device.c for examples.
>
> Anybody can change core code. It just gets looked at closer, and need
> to be generic.
>
>     Andrew
>
Thank you. I will create 2 patches for the core modification and driver 
separately

in next update.