lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 7 Jun 2021 17:18:59 +0800
From:   "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Alexander Potapenko <glider@...gle.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        kasan-dev <kasan-dev@...glegroups.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] lib/test: Fix spelling mistakes



On 2021/6/7 17:06, Andy Shevchenko wrote:
> On Mon, Jun 7, 2021 at 11:56 AM Leizhen (ThunderTown)
> <thunder.leizhen@...wei.com> wrote:
>> On 2021/6/7 16:52, Leizhen (ThunderTown) wrote:
>>> On 2021/6/7 16:39, Andy Shevchenko wrote:
>>>> On Mon, Jun 7, 2021 at 6:21 AM Zhen Lei <thunder.leizhen@...wei.com> wrote:
>>>>
>>>>> Fix some spelling mistakes in comments:
>>>>> thats ==> that's
>>>>> unitialized ==> uninitialized
>>>>> panicing ==> panicking
>>>>> sucess ==> success
>>>>> possitive ==> positive
>>>>> intepreted ==> interpreted
>>>>
>>>> Thanks for the fix! Is it done with the help of the codespell tool? If
>>>> not, can you run it and check if it suggests more fixes?
>>>
>>> Yes, it's detected by codespell tool. But to avoid too many changes in one patch, I tried
>>> breaking it down into smaller patches(If it can be classified) to make it easier to review.
>>> In fact, the other patch I just posted included the rest.
>>
>> https://lkml.org/lkml/2021/6/7/151
>>
>> All the remaining spelling mistakes are fixed by the patch above. I can combine the two of
>> them into one patch if you think it's necessary.
> 
> No, it's good to keep them split. What I meant is to use the tool
> against the same subset of the files you have done your patch for. But
> please mention in the commit message that you have used that tool, so
> reviewers will not waste time on the comments like mine.

Okay, thanks for the advice.

> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ