netdev - Re: [PATCH 2/2] net: stmmac: Add Ingenic SoCs MAC support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62ad605f-3689-cab3-e43e-9b6954da8df3@wanyeetech.com>
Date:   Tue, 8 Jun 2021 21:48:38 +0800
From:   Zhou Yanjie <zhouyanjie@...yeetech.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org,
        peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, rick.tyliu@...enic.com,
        sihui.liu@...enic.com, jun.jiang@...enic.com,
        sernia.zhou@...mail.com, paul@...pouillou.net
Subject: Re: [PATCH 2/2] net: stmmac: Add Ingenic SoCs MAC support.

Hello Andrew,

On 2021/6/8 下午8:21, Andrew Lunn wrote:
> Please wrap your text to around 75 characters per line.


Sure.


>
> I suspect you don't understand RGMII delays. As i said, normally, the
> MAC does not add delays, the PHY does. Please take a closer look at
> this.


According to the description of ethernet-controller.yaml, "rgmii" seems

to allow MAC to add TX delay (the description in ethernet-controller.yaml

is "RX and TX delays are added by the MAC when required"), while rgmii-id

and rgmii-txid do not allow MAC to add delay (the description in

ethernet-controller.yaml is"RGMII with internal RX and TX delays provided

by the PHY, the MAC should not add the RX or TX delays in this case" and

"RGMII with internal TX delay provided by the PHY, the MAC should not add

an TX delay in this case"), I will add support for the other three RGMII 
modes

in the next version (I forgot to reply to this in the previous email).


Thanks and best regards!