netdev - Re: [PATCH V4 00/16] net: iosm: PCIe Driver for Intel M.2 Modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210608.160028.2094273846699936083.davem@davemloft.net>
Date:   Tue, 08 Jun 2021 16:00:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     m.chetan.kumar@...el.com
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        johannes@...solutions.net, krishna.c.sudi@...el.com,
        linuxwwan@...el.com
Subject: Re: [PATCH V4 00/16] net: iosm: PCIe Driver for Intel M.2 Modem


Please fix these build failures, thank you:

drivers/net/wwan/iosm/iosm_ipc_wwan.c:231:21: error: variable ‘iosm_wwan_ops’ has initializer but incomplete type
  231 | static const struct wwan_ops iosm_wwan_ops = {
      |                     ^~~~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c:232:3: error: ‘const struct wwan_ops’ has no member named ‘priv_size’
  232 |  .priv_size = sizeof(struct iosm_netdev_priv),
      |   ^~~~~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c:232:15: warning: excess elements in struct initializer
  232 |  .priv_size = sizeof(struct iosm_netdev_priv),
      |               ^~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c:232:15: note: (near initialization for ‘iosm_wwan_ops’)
drivers/net/wwan/iosm/iosm_ipc_wwan.c:233:3: error: ‘const struct wwan_ops’ has no member named ‘setup’
  233 |  .setup = ipc_wwan_setup,
      |   ^~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c:233:11: warning: excess elements in struct initializer
  233 |  .setup = ipc_wwan_setup,
      |           ^~~~~~~~~~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c:233:11: note: (near initialization for ‘iosm_wwan_ops’)
drivers/net/wwan/iosm/iosm_ipc_wwan.c:234:3: error: ‘const struct wwan_ops’ has no member named ‘newlink’
  234 |  .newlink = ipc_wwan_newlink,
      |   ^~~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c:234:13: warning: excess elements in struct initializer
  234 |  .newlink = ipc_wwan_newlink,
      |             ^~~~~~~~~~~~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c:234:13: note: (near initialization for ‘iosm_wwan_ops’)
drivers/net/wwan/iosm/iosm_ipc_wwan.c:235:3: error: ‘const struct wwan_ops’ has no member named ‘dellink’
  235 |  .dellink = ipc_wwan_dellink,
      |   ^~~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c:235:13: warning: excess elements in struct initializer
  235 |  .dellink = ipc_wwan_dellink,
      |             ^~~~~~~~~~~~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c:235:13: note: (near initialization for ‘iosm_wwan_ops’)
drivers/net/wwan/iosm/iosm_ipc_wwan.c: In function ‘ipc_wwan_init’:
drivers/net/wwan/iosm/iosm_ipc_wwan.c:319:6: error: implicit declaration of function ‘wwan_register_ops’ [-Werror=implicit-function-declaration]
  319 |  if (wwan_register_ops(ipc_wwan->dev, &iosm_wwan_ops, ipc_wwan)) {
      |      ^~~~~~~~~~~~~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c: In function ‘ipc_wwan_deinit’:
drivers/net/wwan/iosm/iosm_ipc_wwan.c:333:2: error: implicit declaration of function ‘wwan_unregister_ops’ [-Werror=implicit-function-declaration]
  333 |  wwan_unregister_ops(ipc_wwan->dev);
      |  ^~~~~~~~~~~~~~~~~~~
drivers/net/wwan/iosm/iosm_ipc_wwan.c: At top level:
drivers/net/wwan/iosm/iosm_ipc_wwan.c:231:30: error: storage size of ‘iosm_wwan_ops’ isn’t known
  231 | static const struct wwan_ops iosm_wwan_ops = {
      |                              ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:272: drivers/net/wwan/iosm/iosm_ipc_wwan.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:515: drivers/net/wwan/iosm] Error 2
make[2]: *** [scripts/Makefile.build:515: drivers/net/wwan] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [scripts/Makefile.build:515: drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....