netdev - Re: [PATCH v2] Bluetooth: fix the erroneous flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YL73vTBtgWkaup+A@eldamar.lan>
Date:   Tue, 8 Jun 2021 06:53:17 +0200
From:   Salvatore Bonaccorso <carnil@...ian.org>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linma <linma@....edu.cn>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Hao Xiong <mart1n@....edu.cn>, stable <stable@...r.kernel.org>
Subject: Re: [PATCH v2] Bluetooth: fix the erroneous flush_work() order

Hi Greg,

On Thu, May 27, 2021 at 10:14:59PM +0200, Marcel Holtmann wrote:
> Hi Greg,
> 
> > In the cleanup routine for failed initialization of HCI device,
> > the flush_work(&hdev->rx_work) need to be finished before the
> > flush_work(&hdev->cmd_work). Otherwise, the hci_rx_work() can
> > possibly invoke new cmd_work and cause a bug, like double free,
> > in late processings.
> > 
> > This was assigned CVE-2021-3564.
> > 
> > This patch reorder the flush_work() to fix this bug.
> > 
> > Cc: Marcel Holtmann <marcel@...tmann.org>
> > Cc: Johan Hedberg <johan.hedberg@...il.com>
> > Cc: Luiz Augusto von Dentz <luiz.dentz@...il.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: linux-bluetooth@...r.kernel.org
> > Cc: netdev@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Signed-off-by: Lin Ma <linma@....edu.cn>
> > Signed-off-by: Hao Xiong <mart1n@....edu.cn>
> > Cc: stable <stable@...r.kernel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> > net/bluetooth/hci_core.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> 
> patch has been applied to bluetooth-stable tree.

Can you queue this one as well for the stable series? It is
6a137caec23aeb9e036cdfd8a46dd8a366460e5d commit upstream and in
5.13-rc5.

Regards,
Salvatore