netdev - RE: [PATCH V1 net-next 0/2] net: fec: fix TX bandwidth fluctuations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB8PR04MB67955C613E293BD1785D9A94E6369@DB8PR04MB6795.eurprd04.prod.outlook.com>
Date:   Wed, 9 Jun 2021 12:03:16 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Frieder Schrempf <frieder.schrempf@...tron.de>,
        Andrew Lunn <andrew@...n.ch>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V1 net-next 0/2] net: fec: fix TX bandwidth fluctuations


Hi Frieder,

> -----Original Message-----
> From: Frieder Schrempf <frieder.schrempf@...tron.de>
> Sent: 2021年6月8日 22:19
> To: Joakim Zhang <qiangqing.zhang@....com>; Andrew Lunn
> <andrew@...n.ch>
> Cc: davem@...emloft.net; kuba@...nel.org; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH V1 net-next 0/2] net: fec: fix TX bandwidth fluctuations
> 
> Hi Joakim, hi Andrew,
> 
> On 08.06.21 05:23, Joakim Zhang wrote:
> >
> > Hi Frieder,
> >
> >> -----Original Message-----
> >> From: Andrew Lunn <andrew@...n.ch>
> >> Sent: 2021年5月27日 22:06
> >> To: Joakim Zhang <qiangqing.zhang@....com>
> >> Cc: davem@...emloft.net; kuba@...nel.org;
> >> frieder.schrempf@...tron.de; netdev@...r.kernel.org;
> >> linux-kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> >> Subject: Re: [PATCH V1 net-next 0/2] net: fec: fix TX bandwidth
> >> fluctuations
> >>
> >> On Thu, May 27, 2021 at 12:10:47PM +0000, Joakim Zhang wrote:
> >>>
> >>> Hi Frieder,
> >>>
> >>> As we talked before, could you please help test the patches when you
> >>> are
> >> free? Thanks.
> >>
> >> Hi Frieder
> >>
> >> If you can, could you also test it with traffic with a mixture of VLAN
> priorities.
> >> You might want to force the link to 10Full, so you can overload it.
> >> Then see what traffic actually makes it through.
> >
> > Did your mailbox get bombed, let you miss this mail, hope you can see this
> reply.
> >
> > Could you please give some feedback if it is possible? Thanks :-)
> 
> Thanks for the patches! As far as the bandwidth drops are concerned, this
> solves the problem. According to my simple iperf tests the untagged TX traffic
> now always goes to queue 0 and therefore doesn't see any random bandwidth
> limitations anymore.
>
> Regarding Andrew's request for testing this with some tagged traffic mix, my
> problem is that though I have used VLANs before and know how to set them up,
> I've never done anything with QoS, so I don't really now how to set the
> priorities (looks like I need to set up internal priorities and egress mapping
> somehow!?). If you have any pointers for this it would be appreciated. I
> probably could do some quick verification tests, but I don't have the time to
> really dive into the topic.

Thanks a lot for your testing! Could I add your t-b and r-b tag when I repost the patches to change functions into static as Jakub commented before?

Best Regards,
Joakim Zhang
> 
> Best regards
> Frieder