netdev - Re: [PATCH net-next 02/13] net: stmmac: reverse Christmas tree notation in stmmac_xpcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210609232843.GC8706@linux.intel.com>
Date:   Thu, 10 Jun 2021 07:28:43 +0800
From:   Wong Vee Khee <vee.khee.wong@...ux.intel.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Ong Boon Leong <boon.leong.ong@...el.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 02/13] net: stmmac: reverse Christmas tree
 notation in stmmac_xpcs_setup

On Wed, Jun 09, 2021 at 09:41:44PM +0300, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Reorder the variable declarations in descending line length order,
> according to the networking coding style.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Wong Vee Khee <vee.khee.wong@...ux.intel.com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> index 3b3033b20b1d..a5d150c5f3d8 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> @@ -399,11 +399,11 @@ int stmmac_mdio_reset(struct mii_bus *bus)
>  
>  int stmmac_xpcs_setup(struct mii_bus *bus)
>  {
> -	int mode, addr;
>  	struct net_device *ndev = bus->priv;
> -	struct dw_xpcs *xpcs;
> -	struct stmmac_priv *priv;
>  	struct mdio_device *mdiodev;
> +	struct stmmac_priv *priv;
> +	struct dw_xpcs *xpcs;
> +	int mode, addr;
>  
>  	priv = netdev_priv(ndev);
>  	mode = priv->plat->phy_interface;
> -- 
> 2.25.1
>