netdev - Re: [PATCH v2] net/mlx5e: Fix an error code in mlx5e_arfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 08 Jun 2021 18:33:51 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     leon@...nel.org, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net/mlx5e: Fix an error code in
 mlx5e_arfs_create_tables()

On Fri, 2021-06-04 at 18:08 +0800, Yang Li wrote:
> When the code execute 'if (!priv->fs.arfs->wq)', the value of err is
> 0.
> So, we use -ENOMEM to indicate that the function
> create_singlethread_workqueue() return NULL.
> 
> Clean up smatch warning:
> drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373
> mlx5e_arfs_create_tables() warn: missing error code 'err'.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Fixes: f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev
> when needed")
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
> 
> Changes in v2:
> --According to Saeed's suggestion, we modify the format of Fixes tag,
> --and initialize err to -ENOMEM.
> https://lore.kernel.org/patchwork/patch/1440018/
> 

applied to net-mlx5.

thanks !