netdev - Re: [PATCH net-next v3 3/9] net: phy: micrel: use consistent indention after define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210610103003.n5jgeppvf4aod5hw@pengutronix.de>
Date:   Thu, 10 Jun 2021 12:30:03 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, kernel@...gutronix.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>
Subject: Re: [PATCH net-next v3 3/9] net: phy: micrel: use consistent
 indention after define

On Thu, May 27, 2021 at 01:24:48AM +0300, Vladimir Oltean wrote:
> On Wed, May 26, 2021 at 06:30:31AM +0200, Oleksij Rempel wrote:
> > This patch changes the indention to one space between "#define" and the
> 
> indention
> /ɪnˈdɛnʃ(ə)n/
> noun
> noun: indention; plural noun: indentions
> 
>     archaic term for indentation.
> 
> Interesting, I learned something new.
> 
> Also, technically it's alignment not indentation.

ok, changed :)

> > macro.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > ---
> >  drivers/net/phy/micrel.c | 24 ++++++++++++------------
> >  1 file changed, 12 insertions(+), 12 deletions(-)
> > 
> > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> > index a14a00328fa3..227d88db7d27 100644
> > --- a/drivers/net/phy/micrel.c
> > +++ b/drivers/net/phy/micrel.c
> > @@ -38,15 +38,15 @@
> >  
> >  /* general Interrupt control/status reg in vendor specific block. */
> >  #define MII_KSZPHY_INTCS			0x1B
> > -#define	KSZPHY_INTCS_JABBER			BIT(15)
> > -#define	KSZPHY_INTCS_RECEIVE_ERR		BIT(14)
> > -#define	KSZPHY_INTCS_PAGE_RECEIVE		BIT(13)
> > -#define	KSZPHY_INTCS_PARELLEL			BIT(12)
> > -#define	KSZPHY_INTCS_LINK_PARTNER_ACK		BIT(11)
> > -#define	KSZPHY_INTCS_LINK_DOWN			BIT(10)
> > -#define	KSZPHY_INTCS_REMOTE_FAULT		BIT(9)
> > -#define	KSZPHY_INTCS_LINK_UP			BIT(8)
> > -#define	KSZPHY_INTCS_ALL			(KSZPHY_INTCS_LINK_UP |\
> > +#define KSZPHY_INTCS_JABBER			BIT(15)
> > +#define KSZPHY_INTCS_RECEIVE_ERR		BIT(14)
> > +#define KSZPHY_INTCS_PAGE_RECEIVE		BIT(13)
> > +#define KSZPHY_INTCS_PARELLEL			BIT(12)
> > +#define KSZPHY_INTCS_LINK_PARTNER_ACK		BIT(11)
> > +#define KSZPHY_INTCS_LINK_DOWN			BIT(10)
> > +#define KSZPHY_INTCS_REMOTE_FAULT		BIT(9)
> > +#define KSZPHY_INTCS_LINK_UP			BIT(8)
> > +#define KSZPHY_INTCS_ALL			(KSZPHY_INTCS_LINK_UP |\
> >  						KSZPHY_INTCS_LINK_DOWN)
> >  #define	KSZPHY_INTCS_LINK_DOWN_STATUS		BIT(2)
> >  #define	KSZPHY_INTCS_LINK_UP_STATUS		BIT(0)
> 
> You left these aligned using tabs.

done.

> > @@ -54,11 +54,11 @@
> >  						 KSZPHY_INTCS_LINK_UP_STATUS)
> >  
> >  /* PHY Control 1 */
> > -#define	MII_KSZPHY_CTRL_1			0x1e
> > +#define MII_KSZPHY_CTRL_1			0x1e
> >  
> >  /* PHY Control 2 / PHY Control (if no PHY Control 1) */
> > -#define	MII_KSZPHY_CTRL_2			0x1f
> > -#define	MII_KSZPHY_CTRL				MII_KSZPHY_CTRL_2
> > +#define MII_KSZPHY_CTRL_2			0x1f
> > +#define MII_KSZPHY_CTRL				MII_KSZPHY_CTRL_2
> >  /* bitmap of PHY register to set interrupt mode */
> >  #define KSZPHY_CTRL_INT_ACTIVE_HIGH		BIT(9)
> >  #define KSZPHY_RMII_REF_CLK_SEL			BIT(7)
> > -- 
> > 2.29.2
> > 
> 
> And the last column of these macros at the end is aligned with spaces
> unlike everything else:
> 
> /* Write/read to/from extended registers */
> #define MII_KSZPHY_EXTREG                       0x0b
> #define KSZPHY_EXTREG_WRITE                     0x8000
> 
> #define MII_KSZPHY_EXTREG_WRITE                 0x0c
> #define MII_KSZPHY_EXTREG_READ                  0x0d
> 
> /* Extended registers */
> #define MII_KSZPHY_CLK_CONTROL_PAD_SKEW         0x104
> #define MII_KSZPHY_RX_DATA_PAD_SKEW             0x105
> #define MII_KSZPHY_TX_DATA_PAD_SKEW             0x106
> 
> I guess if you're going to send this patch you might as well refactor it all.

Ok, done.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |