netdev - Re: [PATCH net-next v4 2/3] net/xfrm: Add inner_ipproto into sec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210610103655.GS40979@gauss3.secunet.de>
Date:   Thu, 10 Jun 2021 12:36:55 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Huy Nguyen <huyn@...dia.com>
CC:     <netdev@...r.kernel.org>, <saeedm@...dia.com>, <borisp@...dia.com>,
        <raeds@...dia.com>, <danielj@...dia.com>, <yossiku@...dia.com>,
        <kuba@...nel.org>
Subject: Re: [PATCH net-next v4 2/3] net/xfrm: Add inner_ipproto into sec_path

On Mon, Jun 07, 2021 at 09:00:45PM +0300, Huy Nguyen wrote:
>  
> +/* For partial checksum offload, the outer header checksum is calculated
> + * by software and the inner header checksum is calculated by hardware.
> + * This requires hardware to know the inner packet type to calculate
> + * the inner header checksum. Save inner ip protocol here to avoid
> + * traversing the packet in the vendor's xmit code.
> + * If the encap type is IPIP, just save skb->inner_ipproto. Otherwise,
> + * get the ip protocol from the IP header.
> + */
> +static void xfrm_get_inner_ipproto(struct sk_buff *skb)
> +{
> +	struct xfrm_offload *xo = xfrm_offload(skb);
> +	const struct ethhdr *eth;
> +
> +	xo = xfrm_offload(skb);

You fetched the xo pointer already above.