netdev - Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMIk0NfOPryoY607@lunn.ch>
Date:   Thu, 10 Jun 2021 16:42:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Zhou Yanjie <zhouyanjie@...yeetech.com>
Cc:     davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org,
        peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, rick.tyliu@...enic.com,
        sihui.liu@...enic.com, jun.jiang@...enic.com,
        sernia.zhou@...mail.com, paul@...pouillou.net
Subject: Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support.

>     We are much more strict about this now than before. You have to use
>     standard units and convert to hardware values. It also makes it a lot
>     easier for DT writers, if they have an idea what the units mean.
> 
>     Having the MAC add small delays is something you can add later,
>     without breaking backwards compatibility. So if you cannot determine
>     what the units are now, just submit the glue driver without support
>     for this feature. If anybody really needs it, they can do the needed
>     research, maybe do some measurements, and then add the code.
> 
> 
> I did an experiment, when the tx delay is not set, RGMII works a

You had rgmii-id in your device tree, so that the PHY added the
delays?

	Andrew