netdev - Re: [PATCH net 1/3] netfilter: nf_tables: initialize set before expression setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Jun 2021 21:50:05 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netfilter-devel@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net 1/3] netfilter: nf_tables: initialize set before
 expression setup

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Thu, 10 Jun 2021 18:54:56 +0200 you wrote:
> nft_set_elem_expr_alloc() needs an initialized set if expression sets on
> the NFT_EXPR_GC flag. Move set fields initialization before expression
> setup.
> 
> [4512935.019450] ==================================================================
> [4512935.019456] BUG: KASAN: null-ptr-deref in nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019487] Read of size 8 at addr 0000000000000070 by task nft/23532
> [4512935.019494] CPU: 1 PID: 23532 Comm: nft Not tainted 5.12.0-rc4+ #48
> [...]
> [4512935.019502] Call Trace:
> [4512935.019505]  dump_stack+0x89/0xb4
> [4512935.019512]  ? nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019536]  ? nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019560]  kasan_report.cold.12+0x5f/0xd8
> [4512935.019566]  ? nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019590]  nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019615]  nf_tables_newset+0xc7f/0x1460 [nf_tables]
> 
> [...]

Here is the summary with links:
  - [net,1/3] netfilter: nf_tables: initialize set before expression setup
    https://git.kernel.org/netdev/net/c/ad9f151e560b
  - [net,2/3] selftests: netfilter: add fib test case
    https://git.kernel.org/netdev/net/c/82944421243e
  - [net,3/3] netfilter: nft_fib_ipv6: skip ipv6 packets from any to link-local
    https://git.kernel.org/netdev/net/c/12f36e9bf678

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html