netdev - Re: [PATCH net-next 4/8] net: phy: fixed formatting issues with braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMN2ItFGaZkKs0H9@lunn.ch>
Date:   Fri, 11 Jun 2021 16:41:38 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Weihang Li <liweihang@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, hkallweit1@...il.com,
        netdev@...r.kernel.org, linuxarm@...wei.com,
        Wenpeng Liang <liangwenpeng@...wei.com>
Subject: Re: [PATCH net-next 4/8] net: phy: fixed formatting issues with
 braces

> -	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) {
> +	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
>  		delay = MII_M1111_RGMII_RX_DELAY | MII_M1111_RGMII_TX_DELAY;
> -	} else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID) {
> +	else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)
>  		delay = MII_M1111_RGMII_RX_DELAY;
> -	} else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) {
> +	else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)
>  		delay = MII_M1111_RGMII_TX_DELAY;
> -	} else {
> +	else
>  		delay = 0;
> -	}

Or turn it into a switch statement?

   Andrew