netdev - Re: [PATCH v2] bus: mhi: Add inbound buffers allocation flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210612064722.GA22149@thinkpad>
Date:   Sat, 12 Jun 2021 12:17:22 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Loic Poulain <loic.poulain@...aro.org>,
        David Miller <davem@...emloft.net>,
        Hemant Kumar <hemantk@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Bhaumik Bhatt <bbhatt@...eaurora.org>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] bus: mhi: Add inbound buffers allocation flag

On Fri, Jun 11, 2021 at 11:31:17AM -0700, Jakub Kicinski wrote:
> On Fri, 11 Jun 2021 09:00:16 +0200 Loic Poulain wrote:
> > > On Fri, May 21, 2021 at 03:25:19PM +0200, Loic Poulain wrote:  
> > > > Currently, the MHI controller driver defines which channels should
> > > > have their inbound buffers allocated and queued. But ideally, this is
> > > > something that should be decided by the MHI device driver instead,
> > > > which actually deals with that buffers.
> > > >
> > > > Add a flag parameter to mhi_prepare_for_transfer allowing to specify
> > > > if buffers have to be allocated and queued by the MHI stack.
> > > >
> > > > Keep auto_queue flag for now, but should be removed at some point.
> > > >
> > > > Signed-off-by: Loic Poulain <loic.poulain@...aro.org>
> > > > Tested-by: Bhaumik Bhatt <bbhatt@...eaurora.org>
> > > > Reviewed-by: Bhaumik Bhatt <bbhatt@...eaurora.org>
> > > > Reviewed-by: Hemant Kumar <hemantk@...eaurora.org>
> > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > > > ---
> > > >  v2: Update API in mhi_wwan_ctrl driver
> > > >
> > > >  drivers/bus/mhi/core/internal.h  |  2 +-
> > > >  drivers/bus/mhi/core/main.c      | 11 ++++++++---
> > > >  drivers/net/mhi/net.c            |  2 +-
> > > >  drivers/net/wwan/mhi_wwan_ctrl.c |  2 +-  
> > >
> > > Since this patch touches the drivers under net/, I need an Ack from Dave or
> > > Jakub to take it via MHI tree.  
> > 
> > Could you please ack|nack this patch?
> 
> Looks fine.

Thanks, I'll take it as an Ack.

Regards,
Mani