netdev - Re: [PATCH iproute2] tc: pedit: add decrement operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210614142540.37eded6f@hermes.local>
Date:   Mon, 14 Jun 2021 14:25:40 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Asbjørn Sloth Tønnesen 
        <asbjorn@...jorn.st>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH iproute2] tc: pedit: add decrement operation

On Mon, 14 Jun 2021 20:33:24 +0000
Asbjørn Sloth Tønnesen         <asbjorn@...jorn.st> wrote:

> @@ -422,16 +434,21 @@ int parse_cmd(int *argc_p, char ***argv_p, __u32 len, int type, __u32 retain,
>  		goto done;
>  	}
>  
>  	return -1;
> +


Please no unnecessary whitespace changes.

Also you are missing to print_pedit() to print the resulting change.