netdev - RE: [net-next, v2, 7/7] enetc: support PTP domain timestamp conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB7PR04MB5017DDA1D4A01D4629CEB670F8309@DB7PR04MB5017.eurprd04.prod.outlook.com>
Date:   Tue, 15 Jun 2021 09:44:19 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: RE: [net-next, v2, 7/7] enetc: support PTP domain timestamp
 conversion

Hi Richard,

> -----Original Message-----
> From: Richard Cochran <richardcochran@...il.com>
> Sent: 2021年5月31日 21:49
> To: Y.b. Lu <yangbo.lu@....com>
> Cc: netdev@...r.kernel.org; David S . Miller <davem@...emloft.net>; Claudiu
> Manoil <claudiu.manoil@....com>; Jakub Kicinski <kuba@...nel.org>
> Subject: Re: [net-next, v2, 7/7] enetc: support PTP domain timestamp
> conversion
> 
> On Mon, May 31, 2021 at 11:26:18AM +0000, Y.b. Lu wrote:
> > So, the timestamp conversion could be in skbuff.c.
> > That's good to do this. But there are quite a lot of drivers using
> timestamping.
> > Should we convert all drivers to use the helper, or let others do this when
> they need?
> 
> I think we should convert them all.  Yes, it is work, but I will help.
> I really like the vclock idea, especially because it will work with every clock.
> Also, adding the helper will be a nice refactoring all by itself.

It seems socket.c __sock_recv_timestamp may be the better place.
HW timestamps are handled in it before going to user space.
I sent out a v3 patch for your reviewing. Maybe we don’t have to convert all drivers to a helper.
Thank you very much.

> 
> Thanks,
> Richard