netdev - Re: [PATCH] vmxnet3: prevent building with 256K pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76ccb9fc-dc43-46e1-6465-637b72253385@csgroup.eu>
Date:   Tue, 15 Jun 2021 14:41:34 +0200
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Michael Ellerman <mpe@...erman.id.au>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        pv-drivers@...are.com, doshir@...are.com
Subject: Re: [PATCH] vmxnet3: prevent building with 256K pages



Le 15/06/2021 à 14:35, Michael Ellerman a écrit :
> This driver assigns PAGE_SIZE to a u16, which can't work when the page
> size is 256K. As reported by lkp:
> 
>   drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init':
>   arch/powerpc/include/asm/page.h:24:20: warning: conversion from 'long unsigned int' to 'u16' changes value from '262144' to '0'
>   drivers/net/vmxnet3/vmxnet3_drv.c:1784:29: note: in expansion of macro 'PAGE_SIZE'
>    1784 |    rq->buf_info[0][i].len = PAGE_SIZE;
>                                       ^~~~~~~~~
> 
> Simliar to what was done previously in commit fbdf0e28d061 ("vmxnet3:
> prevent building with 64K pages"), prevent the driver from building when
> 256K pages are enabled.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
> ---
>   drivers/net/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 74dc8e249faa..da46898f060a 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -549,7 +549,7 @@ config VMXNET3
>   	depends on PCI && INET
>   	depends on !(PAGE_SIZE_64KB || ARM64_64K_PAGES || \
>   		     IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \
> -		     PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES)
> +		     PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES || PPC_256K_PAGES)

Maybe we should also exclude hexagon, same as my patch on BTRFS 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/a16c31f3caf448dda5d9315e056585b6fafc22c5.1623302442.git.christophe.leroy@csgroup.eu/

>   	help
>   	  This driver supports VMware's vmxnet3 virtual ethernet NIC.
>   	  To compile this driver as a module, choose M here: the
>